fix: Fixed non-docker running of the Flask server #30
Conversation
frgfm
added
type: bug
The server was running indefinitely
frgfm
requested review from
pechouc,
VincGargasson,
abdi-adel,
Akilditu and
nrslt
There was a problem hiding this comment.
Thanks a lot @frgfm! I am not an expert at all and I don't really have enough time to dig deeper but I fully trust your input 😄
I just have a small question about requirements that are displayed as erased in the requirements.txt and which we are using for the web-app. Sorry if I have missed something obvious about this!
| @@ -2,11 +2,9 @@ wheel>=0.29 | |||
| pandas>=0.24.2 | |||
| numpy>=1.18.4 | |||
| dash>=1.16.2 | |||
| dash-core-components>=1.12.1 | |||
| dash-html-components>=1.1.1 | |||
There was a problem hiding this comment.
I am not sure to understand why we are erasing these requirements here?
There was a problem hiding this comment.
This is quite optional, it's more cosmetics than anything else: they are direct dependencies of dash so installing dash installs these :)
There was a problem hiding this comment.
Oh ok, I thought I had to install them separately when I first installed dash, nice catch!
In #29, the need to have env variables was introduced. This PR introduces the following features:
Any feedback is welcome!