Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed CUDA collection for v11+ #98

Merged
merged 2 commits into from
Feb 7, 2021
Merged

fix: Fixed CUDA collection for v11+ #98

merged 2 commits into from
Feb 7, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Feb 7, 2021

As mentioned @MateoLostanlen in #96, the CUDA version collection was failing with our current version of the script. As suspected, this is due to the regex used not being compatible with nvcc console output after version 11 cf. pytorch/pytorch#51840

This PR fixes this using what was mentioned in the above issue, and now works both for CUDA>= 11 and CUDA < 11

@frgfm frgfm added type: enhancement New feature or request ext: scripts labels Feb 7, 2021
@frgfm frgfm added this to the 0.1.1 milestone Feb 7, 2021
@frgfm frgfm self-assigned this Feb 7, 2021
@MateoLostanlen
Copy link
Member

Hi @frgfm, thanks for the PR. Unfortunately, I still have the same output:

Collecting environment information...
Pyrovision version: 0.2.0a0
PyTorch version: 1.7.1
Torchvision version: 0.8.2

OS: Microsoft Windows 10 Home

Python version: 3.8
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: Could not collect
Nvidia driver version: Could not

@frgfm
Copy link
Member Author

frgfm commented Feb 7, 2021

Hi @frgfm, thanks for the PR. Unfortunately, I still have the same output:

Strange, it fixed it on my end! Could you post the output of the following commands please ?

nvcc --version
"C:\\Program Files\\NVIDIA Corporation\\NVSMI\\nvidia-smi"
"C:\\Program Files\\NVIDIA Corporation\\NVSMI\\nvidia-smi" -L

I may have to adapt the regex for windows support if this happens to be the issue.

@MateoLostanlen
Copy link
Member

Ok I think the issue is on my side, nvcc was not working, now I have :

python scripts\collect_env.py
Collecting environment information...
Pyrovision version: 0.2.0a0
PyTorch version: 1.7.1
Torchvision version: 0.8.2

OS: Microsoft Windows 10 Home

Python version: 3.8
Is CUDA available: Yes
CUDA runtime version: 11.2.67
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Could not collect

and for your command :

 nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Mon_Nov_30_19:15:10_Pacific_Standard_Time_2020
Cuda compilation tools, release 11.2, V11.2.67
Build cuda_11.2.r11.2/compiler.29373293_0

Maybe one of the drivers is missing on my side

@frgfm
Copy link
Member Author

frgfm commented Feb 7, 2021

@MateoLostanlen good news then! It looks like you still have issues with nvidia-smi but the rest looks good 👌
We can move forward with the PR review I think

@frgfm frgfm merged commit 8366787 into master Feb 7, 2021
@frgfm frgfm deleted the cuda-collection branch February 7, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants