Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI check for generate examples #934

Closed
metalmatze opened this issue Oct 4, 2023 · 0 comments · Fixed by #957
Closed

Run CI check for generate examples #934

metalmatze opened this issue Oct 4, 2023 · 0 comments · Fixed by #957
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@metalmatze
Copy link
Member

As occurred in #933 and from experience, we should definitely have a CI check that checks if files have been modified to result in differences in the generated files.
kube-prometheus is probably a fantastic resource to look at for this.
@metalmatze metalmatze added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 4, 2023
squat added a commit to squat/pyrra that referenced this issue Oct 20, 2023
@squat
CI: add job to check Jsonnet
e90d27b 
This commit adds a workflow for generated files with a job to check
Jsonnet in the examples/ directory. I tested this locally with act and
correctly got a diff and a failure when bumping the Pyrra version in
examples/openshift.main.jsonnet.

Fixes: pyrra-dev#934

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
@squat squat mentioned this issue Oct 20, 2023
Merged
squat added a commit to squat/pyrra that referenced this issue Oct 20, 2023
@squat
CI: add job to check Jsonnet
bc891a1 
This commit adds a workflow for generated files with a job to check
Jsonnet in the examples/ directory. I tested this locally with act and
correctly got a diff and a failure when bumping the Pyrra version in
examples/openshift.main.jsonnet.

Fixes: pyrra-dev#934

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat added a commit to squat/pyrra that referenced this issue Oct 20, 2023
@squat
CI: add job to check Jsonnet
49a5653 
This commit adds a workflow for generated files with a job to check
Jsonnet in the examples/ directory. I tested this locally with act and
correctly got a diff and a failure when bumping the Pyrra version in
examples/openshift.main.jsonnet.

Fixes: pyrra-dev#934

Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: add job to check Jsonnet squat/pyrra
1 participant
@metalmatze