Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md #125

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Add CONTRIBUTING.md #125

merged 2 commits into from
Feb 14, 2022

Conversation

obitech
Copy link
Contributor

@obitech obitech commented Feb 14, 2022

Closes #124

@metalmatze
Copy link
Member

Amazing. Thanks!
With this addition and moving things into a different file, we should probably clean up https://github.com/pyrra-dev/pyrra#run-locally to not duplicate things in the future?

@obitech
Copy link
Contributor Author

obitech commented Feb 14, 2022

we should probably clean up https://github.com/pyrra-dev/pyrra#run-locally

Good point. Should we just move the whole block into CONTRIBUTING.md ?

@metalmatze
Copy link
Member

Yes, if you could merge these into CONTRIBUTING.md that would be perfect! 👍

@obitech
Copy link
Contributor Author

obitech commented Feb 14, 2022

I've moved it, PTAL 😌

metalmatze
metalmatze approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super amazing. Thank you so much for taking care of this! 🚀

@metalmatze metalmatze merged commit cb5ba30 into pyrra-dev:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a CONTRIBUTING.md
2 participants
@obitech @metalmatze