Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add exhaustion label to alerts #787

Merged
merged 3 commits into from
Jul 14, 2023
Merged

feat: Add exhaustion label to alerts #787

merged 3 commits into from
Jul 14, 2023

Conversation

achetronic
Copy link
Contributor

Description:

Add a label to alerts with exhaustion duration information. This is useful for crafting meaningful alert messages for developers. In another PR I will add a description and summary for the alerts 🙏🏼

@achetronic
Copy link
Contributor Author

@metalmatze hey there, I saw some test failed, I will fix it ofc. WDYT about this little feature?

@achetronic
Copy link
Contributor Author

@metalmatze Tests fixed :)

@metalmatze
Copy link
Member

Thank you so much for this contribution! 🎉
I refactored some parts into a method using simpler type casting.

@metalmatze metalmatze merged commit b5e1cca into pyrra-dev:main Jul 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants