kubernetes/api: Add validation for latencyNative indicators

kubernetes/api/v1alpha1/servicelevelobjective_types.go

@@ -297,6 +297,25 @@ func (in *ServiceLevelObjective) validate() (admission.Warnings, error) {
 		}
 	}
 
+	if in.Spec.ServiceLevelIndicator.LatencyNative != nil {
+		latencyNative := in.Spec.ServiceLevelIndicator.LatencyNative
+		if latencyNative.Total.Metric == "" {
+			return warnings, fmt.Errorf("latencyNative total metric must be set")
+		}
+		if latencyNative.Latency == "" {
+			return warnings, fmt.Errorf("latencyNative latency objective must be set")
+		}
+
+		if _, err := model.ParseDuration(latencyNative.Latency); err != nil {
+			return warnings, fmt.Errorf("latencyNative latency objective must be a valid duration: %w", err)
+		}
+
+		_, err := parser.ParseExpr(latencyNative.Total.Metric)
+		if err != nil {
+			return warnings, fmt.Errorf("failed to parse latencyNative total metric: %w", err)
+		}
+	}
+
 	return warnings, nil
 }
 

kubernetes/api/v1alpha1/servicelevelobjective_types_test.go

@@ -564,4 +564,75 @@ func TestServiceLevelObjective_Validate(t *testing.T) {
 			require.EqualError(t, err, `latency success metric must contain a le label matcher with a float value: strconv.ParseFloat: parsing "foo": invalid syntax`)
 		})
 	})
+
+	t.Run("latencyNative", func(t *testing.T) {
+		latencyNative := func() *v1alpha1.ServiceLevelObjective {
+			return &v1alpha1.ServiceLevelObjective{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "name",
+					Namespace: "namespace",
+				},
+				Spec: v1alpha1.ServiceLevelObjectiveSpec{
+					Target: "99",
+					Window: "2w",
+					ServiceLevelIndicator: v1alpha1.ServiceLevelIndicator{
+						LatencyNative: &v1alpha1.NativeLatencyIndicator{
+							Latency:  "1s",
+							Total:    v1alpha1.Query{Metric: `foo{foo="bar"}`},
+							Grouping: nil,
+						},
+					},
+				},
+			}
+		}
+
+		warn, err := latencyNative().ValidateCreate()
+		require.NoError(t, err)
+		require.Nil(t, warn)
+
+		t.Run("empty", func(t *testing.T) {
+			ln := latencyNative()
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Total.Metric = ""
+			warn, err := ln.ValidateCreate()
+			require.EqualError(t, err, "latencyNative total metric must be set")
+			require.Nil(t, warn)
+
+			ln = latencyNative()
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Latency = ""
+			warn, err = ln.ValidateCreate()
+			require.EqualError(t, err, "latencyNative latency objective must be set")
+			require.Nil(t, warn)
+		})
+
+		t.Run("invalidLatency", func(t *testing.T) {
+			ln := latencyNative()
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Latency = "foo"
+			warn, err := ln.ValidateCreate()
+			require.EqualError(t, err, `latencyNative latency objective must be a valid duration: not a valid duration string: "foo"`)
+			require.Nil(t, warn)
+		})
+
+		t.Run("invalidMetric", func(t *testing.T) {
+			ln := latencyNative()
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Total.Metric = "foo{"
+			warn, err := ln.ValidateCreate()
+			require.EqualError(t, err, "failed to parse latencyNative total metric: 1:5: parse error: unexpected end of input inside braces")
+			require.Nil(t, warn)
+
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Total.Metric = "foo}"
+			warn, err = ln.ValidateCreate()
+			require.EqualError(t, err, "failed to parse latencyNative total metric: 1:4: parse error: unexpected character: '}'")
+			require.Nil(t, warn)
+
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Total.Metric = "$$$"
+			warn, err = ln.ValidateCreate()
+			require.EqualError(t, err, "failed to parse latencyNative total metric: 1:1: parse error: unexpected character: '$'")
+			require.Nil(t, warn)
+
+			ln.Spec.ServiceLevelIndicator.LatencyNative.Total.Metric = `foo{foo="bar'}`
+			warn, err = ln.ValidateCreate()
+			require.EqualError(t, err, "failed to parse latencyNative total metric: 1:9: parse error: unterminated quoted string")
+			require.Nil(t, warn)
+		})
+	})
 }