Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing tests (numpy outputting data type in addition to the value) #218

Closed
weikang9009 opened this issue Jun 24, 2024 · 4 comments
Closed

Comments

@weikang9009
Copy link
Member

The tests are failing
https://github.com/pysal/giddy/actions/runs/9648038464/job/26608252448#step:7:194

It seems to be due to the changed behavior of the output of numpy - in addition to outputting the value, the data type is output as well. Any thoughts on resolving this?

@sjsrey
Copy link
Member

sjsrey commented Jun 24, 2024

@jGaboardi
Copy link
Member

Yeah, it affects the doctests:

So for spaghetti, I simply updated the expected output for those failing tests.

@weikang9009
Copy link
Member Author

I see. Thank you!

@martinfleis
Copy link
Member

The only thing that changed is the __repr__ of numpy dtypes. These were always numpy objects, you just couldn't tell from the notebook output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants