-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docstring tests -- numpy-2.0
failures
#769
Conversation
Can we maybe try to fix it rather than disabling failing tests? |
Yes, this was done in haste yesterday evening. I'm on the fence as to:
Very worth noting that none of the actual functional tests fail, only the docstring examples. |
Not worth it imho, just creates unnecessary copies of data. |
numpy-2.0
failuresnumpy-2.0
failures
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
=====================================
Coverage 99.3% 99.3%
=====================================
Files 4 4
Lines 1133 1133
=====================================
Hits 1125 1125
Misses 8 8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in numpy 2 is so annoying...
|
||
|
||
- name: declare doctest run | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add that as a To DO issue.
This PR