New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement `rose.plot()` and `rose.plot_vectors()` method using `splot` #43

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
3 participants
@slumnitz
Copy link
Member

slumnitz commented Jun 20, 2018

implementation of methods calling splot functionality

using try: import splot.giddy and a warning
to allow for use of current .plot() method and easy switch to splot after release

implement `rose.plot()` and `rose.plot_vectors()` method using `splot`
using `try: import splot.giddy` and a warning
to allow for use of current `.plot()` method and easy switch to `splot` after release
@slumnitz

This comment has been minimized.

Copy link
Member Author

slumnitz commented Jun 20, 2018

@sjsrey @darribas @ljwolf @TaylorOshan @jorisvandenbossche this how an integration of splot functionality as a method could look like. What do you think?

use_splot = True
except ImportError:
warnings.warn('To get better results, please install the `splot` package',
UserWarning)

This comment has been minimized.

@jorisvandenbossche

jorisvandenbossche Jun 22, 2018

If the final goal is to remove the custom code here below (for case of use_splot = False), I would give a stronger message (and make it a DeprecationWarning) making it clear in the future having splot installed will be required.

@jorisvandenbossche

This comment has been minimized.

Copy link

jorisvandenbossche commented Jun 22, 2018

(but for the rest looks good!)

@sjsrey

sjsrey approved these changes Jun 25, 2018

Copy link
Member

sjsrey left a comment

Looks good.

@sjsrey sjsrey merged commit 567c28d into pysal:master Jun 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment