implement rose.plot() and rose.plot_vectors() method using splot
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using `try: import splot.giddy` and a warning to allow for use of current `.plot()` method and easy switch to `splot` after release
|
@sjsrey @darribas @ljwolf @TaylorOshan @jorisvandenbossche this how an integration of |
| use_splot = True | ||
| except ImportError: | ||
| warnings.warn('To get better results, please install the `splot` package', | ||
| UserWarning) |
There was a problem hiding this comment.
If the final goal is to remove the custom code here below (for case of use_splot = False), I would give a stronger message (and make it a DeprecationWarning) making it clear in the future having splot installed will be required.
|
(but for the rest looks good!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of methods calling splot functionality
using
try: import splot.giddyand a warningto allow for use of current
.plot()method and easy switch tosplotafter release