WIP debugging travis failure #141
Conversation
There was a problem hiding this comment.
@sjsrey I am just pushing nearly the same solution, but you beat me to the punch. In my branch I created a requirements_plus_conda.txt and requirements_plus_pip.txt. Do you think your method of directly doing pip install geomet in the .travis.yml or my method is the more streamlined and adaptable model?
jGaboardi
added
rough edge
|
@jGaboardi not sure what is the best way. For some reason my tests are not getting triggered on my fork so i'm pr'ing into upstream to hopefully trigger a test. |
|
@sjsrey I think yours weren't being triggered because mine were running. |
|
or maybe not... |
|
being addressed in #140 |
.travis.yml
Outdated
| @@ -24,7 +24,8 @@ before_install: | |||
| install: | |||
| - conda install --yes pip | |||
| - if [ "$PYSAL_PLUS" == true ]; then | |||
| echo 'plus testing'; pip install -r requirements_plus.txt; | |||
| echo 'plus testing'; conda install --yes --file requirements_plus.txt; | |||
| pip install geomat; | |||
There was a problem hiding this comment.
I think the method for having and additional requirements_plus_pip.txt is the way to go because we can list it within setup.py, like here.
|
@sjsrey can this be closed now? |
No description provided.