Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle connection errors for remote datasets #274

Merged
merged 5 commits into from
Apr 1, 2020
Merged

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Apr 1, 2020

Addressing #259

@sjsrey sjsrey added the WIP Work in progress, do not merge. Discussion only. label Apr 1, 2020
@sjsrey sjsrey requested a review from jGaboardi April 1, 2020 03:37
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #274 into master will decrease coverage by 0.01%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   81.00%   80.99%   -0.02%     
==========================================
  Files         115      115              
  Lines       11572    11580       +8     
==========================================
+ Hits         9374     9379       +5     
- Misses       2198     2201       +3     
Impacted Files Coverage Δ
libpysal/examples/remotes.py 83.56% <94.91%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4369a48...3f062ef. Read the comment docs.

@jGaboardi jGaboardi added examples rough edge Something that's not a bug, but that gets in the way of "it just works." labels Apr 1, 2020
@sjsrey
Copy link
Member Author

sjsrey commented Apr 1, 2020

I thought keeping them together might have been a way to fix the missing gp issue. So that didn't work and we can go back to separating them.

@jGaboardi
Copy link
Member

I thought keeping them together might have been a way to fix the missing gp issue. So that didn't work and we can go back to separating them.

Let's keep them separate. Having them separate is better for debugging (so that each command is visible in the actions log) and does not affect the activated Python environment.

@jGaboardi
Copy link
Member

I'll just go ahead make changes to the .yml in this PR or do you want to?

@jGaboardi jGaboardi self-requested a review April 1, 2020 21:02
@jGaboardi jGaboardi merged commit 14c7509 into pysal:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples rough edge Something that's not a bug, but that gets in the way of "it just works." WIP Work in progress, do not merge. Discussion only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants