Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GHA #65

Merged
merged 13 commits into from
May 18, 2020
Merged

Migrate to GHA #65

merged 13 commits into from
May 18, 2020

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented May 17, 2020

This PR addresses #64 (among other housekeeping stuff).

  • updates setup.py for pytest and Python 3.8
  • adds a custom codecov.yml that only comments after 18 builds
  • updates the requirements files
  • removes travis/appveyor yamls
  • updates MANIFEST
  • removes unused README.rst
  • removes readthedocs.yml

In order for this to work properly the CODECOV_TOKEN will have to be set in Setting/Secrets from codecov.io.

@jGaboardi
Copy link
Member Author

@sjsrey IIRC this should be merged before the GHA kick in. Also, TravisCI should be disable now that mapclassify is on GHA.

@jGaboardi jGaboardi requested a review from sjsrey May 17, 2020 17:38
@sjsrey
Copy link
Member

sjsrey commented May 17, 2020

This PR addresses #64 (among other housekeeping stuff).

* updates `setup.py` for `pytest` and Python 3.8

* adds a custom `codecov.yml` that only comments after 18 builds

* updates the requirements files

In order for this to work properly the CODECOV_TOKEN will have to be set in Setting/Secrets from codecov.io.

Are there directions on how to do that?

@jGaboardi
Copy link
Member Author

This PR addresses #64 (among other housekeeping stuff).

* updates `setup.py` for `pytest` and Python 3.8

* adds a custom `codecov.yml` that only comments after 18 builds

* updates the requirements files

In order for this to work properly the CODECOV_TOKEN will have to be set in Setting/Secrets from codecov.io.

Are there directions on how to do that?

I would do this but I don't have admin rights to mapclassify.

  1. Copy the token from Repository Upload Token at codecov.io.
  2. Go to the Settings tab on the far top right of the repo (Code, Issue, ..., Settings).
  3. Go to Secrets near the bottom of the first box on the left panel.
  4. Click New Secret at the top of the Secrets page.
  5. Enter CODECOV_TOKEN as the name and paste in the token from (1) as the value.

@sjsrey sjsrey merged commit 6f34d2c into pysal:master May 18, 2020
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@jGaboardi jGaboardi deleted the gha branch May 18, 2020 02:09
@sjsrey
Copy link
Member

sjsrey commented May 18, 2020

Fantastic job @jGaboardi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants