-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question about final fit in MGWR class? #1
Comments
Hmm, I'm not sure if I copied that over from @weikang9009 original version or if I perhaps did that when trying to fit the original version in to this GWR framework and somehow spaced out on the fact that XB was the final params. If XB.sum(axis=1) gives you the proper predicted values of y, than this can/should be massively simplified. Makes sense to me. Maybe I started to prepare for the computation of some other diagnostics, but never followed through. Also seems I've unnecessarily reassigned the |
I'll keep playing around with it, but one thing I do know is that the row-sum of the final Also, neither the final |
Final fit is now carried over from model estimation |
* Create unittest.yml Add unites action * Create 37.yaml * Update 37.yaml * Create 38.yaml * Create 39.yaml * Create 39-DEV.yaml * Update 39-DEV.yaml * Delete .travis.yml
https://github.com/pysal/gwr_private/blob/2e666645a8fd0acf4eeec7ee18844db9f4ba484c/mgwr/gwr.py#L1057
Why do we do this second pass on the fit after already having the final XB values from the backfitting algorithim in Sel_BW?
I thought that the last iteration of the backfit is the "converged" values of each smooth?
The text was updated successfully, but these errors were encountered: