Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unittest.yml #115

Merged
merged 4 commits into from
Mar 7, 2022
Merged

update unittest.yml #115

merged 4 commits into from
Mar 7, 2022

Conversation

Ziqi-Li
Copy link
Member

@Ziqi-Li Ziqi-Li commented Mar 6, 2022

Fixing test failed due to timeout in Actions. Changed from 30 minutes to 60 minutes.

Fix test timeout in Actions. Changed from 30 minutes to 60 minutes.
@jGaboardi
Copy link
Member

Might want to specify a timeout if a test is taking too long. See this PR in spaghetti.

Ziqi-Li and others added 3 commits March 6, 2022 17:49
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #115 (2846664) into master (eef4f70) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #115     +/-   ##
========================================
+ Coverage    89.0%   89.1%   +0.1%     
========================================
  Files          12      12             
  Lines        3000    3000             
========================================
+ Hits         2671    2674      +3     
+ Misses        329     326      -3     
Impacted Files Coverage Δ
mgwr/utils.py 4.6% <0.0%> (+4.6%) ⬆️

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Mar 6, 2022

Might want to specify a timeout if a test is taking too long. See this PR in spaghetti.

Thanks for that!

@jGaboardi
Copy link
Member

Let's also add in a 3.10 test environment in another PR.

@Ziqi-Li
Copy link
Member Author

Ziqi-Li commented Mar 7, 2022

Let's also add in a 3.10 test environment in another PR.

Ok, will do.

@Ziqi-Li Ziqi-Li merged commit 2a95535 into pysal:master Mar 7, 2022
@Ziqi-Li Ziqi-Li deleted the fix-test branch January 10, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants