Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout test is stalling #668

Merged
merged 5 commits into from Feb 12, 2022
Merged

Timeout test is stalling #668

merged 5 commits into from Feb 12, 2022

Conversation

jGaboardi
Copy link
Member

This PR addresses #666 by adding a timeout if the test stalls.

@jGaboardi jGaboardi self-assigned this Feb 12, 2022
martinfleis
martinfleis reviewed Feb 12, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this plugin but isn't specifying both --timeout=60 and @pytest.mark.timeout(60) redundant?

@jGaboardi
Copy link
Member Author

I don't know this plugin but isn't specifying both --timeout=60 and @pytest.mark.timeout(60) redundant?

Maybe yes. I tried by marking only the specific test (@pytest.mark.timeout(60)), which failed. Let's try again with only the global declared (--timeout=60).

martinfleis
martinfleis approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@jGaboardi jGaboardi merged commit 0dbc28d into pysal:main Feb 12, 2022
@jGaboardi jGaboardi deleted the timeout_test branch February 12, 2022 20:34
@jGaboardi jGaboardi mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@knaaptime knaaptime Awaiting requested review from knaaptime

Assignees

@jGaboardi jGaboardi

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jGaboardi @martinfleis