Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose buffer variable #649

Merged
merged 3 commits into from
Jul 19, 2024
Merged

expose buffer variable #649

merged 3 commits into from
Jul 19, 2024

Conversation

u3ks
Copy link
Collaborator

@u3ks u3ks commented Jul 19, 2024

Expose the buffer variable for perimeter_walls and courtyards

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (bb56aef).
Report is 78 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #649     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.7%     
=======================================
  Files         26      38     +12     
  Lines       4328    6314   +1986     
=======================================
+ Hits        4214    6191   +1977     
- Misses       114     123      +9     
Files Coverage Δ
momepy/functional/_dimension.py 100.0% <ø> (ø)
momepy/functional/_intensity.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_dimension.py 100.0% <100.0%> (ø)
momepy/functional/tests/test_intensity.py 100.0% <100.0%> (ø)

@u3ks u3ks requested a review from martinfleis July 19, 2024 11:56
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jGaboardi jGaboardi added the enhancement New feature or request label Jul 19, 2024
Copy link
Member

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo -- LGTM

momepy/functional/_dimension.py Outdated Show resolved Hide resolved
Co-authored-by: James Gaboardi <jgaboardi@gmail.com>
@martinfleis martinfleis merged commit 283f45a into pysal:main Jul 19, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants