-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta update for 2-3 conversion #654
Comments
Or try to futureproof requests stuff. |
I'm curious about the motivation for this. pstephen@happyendings ~/D/pysal> grep -r urllib2 . |
In PySAL-REST we have been using requests and that package has been significantly more pleasant to use than url lib. It looks like 99% of the url lib stuff is in either contrib or pseudo-experimental code. Is that the case? If so, and assuming we are pegging to anaconda/canopy then I would +1 the requests module. |
There's also an idiom in six that may be easier than reimplementation in Requests, especially if requests doesn't support arbitrary chomp sizes. |
I've tried a mutually-compatible version using I'll be running the doctests to check. If there are meta tests in the works, it'd be great to know. |
I'd like to close this, but currently meta isn't even importable from PySAL: >>> import pysal as ps
>>> from pysal import meta as m
---------------------------------------------------------------------------
ImportError Traceback (most recent call last)
<ipython-input-4-22096d9ee5b5> in <module>()
----> 1 from pysal import meta as m
ImportError: cannot import name 'meta'
>>> ps.version
'1.11.2' |
swap out urllib2 for and use requests or httplib
The text was updated successfully, but these errors were encountered: