-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy imports and addition of access package #1180
Conversation
test all functions using lazy import structure
need to add access to |
@sjsrey the whole readme is now lowercase. I assume that was not an intention? |
Good catch! No, that wasn't the intention. I will have to see what automated that? |
download example data
On this, tab completion still works on my end. However, the API is a bit polluted now. >>> import pysal
>>> dir(pysal)
['__builtins__',
'__cached__',
'__doc__',
'__file__',
'__loader__',
'__name__',
'__package__',
'__path__',
'__spec__',
'__version__',
'base', # this is new, not in the hierarchy
'explore',
'federation_hierarchy', # this is also new
'lib',
'memberships', # This is also new
'model',
'versions', # this is also new
'viz'] I'd think |
After a bit more introspection, the tab completion is a little awkward for the layers. It works fine for the packages once they're imported from the layers, but there is a bit of a lag completing on the layer name. In addition it does pollute the namespace so I think we can roll back for now and revisit it after the 2.3 release. |
@@ -20,6 +20,7 @@ | |||
'pointpats': 'explore', | |||
'inequality': 'explore', | |||
'spaghetti': 'explore', | |||
'access': 'access', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 'access': 'model',
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - good catch!
Replacing this with #1189 |
This starts the 2.3.0 release target