Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy imports and addition of access package #1180

Closed
wants to merge 45 commits into from
Closed

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented May 23, 2020

This starts the 2.3.0 release target

@sjsrey sjsrey added the WIP Work in progress, do not merge. Discussion only. label May 23, 2020
@knaaptime
Copy link
Member

need to add access to envioronment.yml

pysal/frozen.py Outdated Show resolved Hide resolved
@sjsrey sjsrey changed the title [WIP] Lazy imports and addition of access package Lazy imports and addition of access package Jul 12, 2020
@sjsrey sjsrey removed the WIP Work in progress, do not merge. Discussion only. label Jul 12, 2020
@sjsrey sjsrey requested a review from martinfleis July 12, 2020 18:39
@martinfleis
Copy link
Member

@sjsrey the whole readme is now lowercase. I assume that was not an intention?

@sjsrey
Copy link
Member Author

sjsrey commented Jul 12, 2020

@sjsrey the whole readme is now lowercase. I assume that was not an intention?

Good catch! No, that wasn't the intention. I will have to see what automated that?

@ljwolf
Copy link
Member

ljwolf commented Jul 14, 2020

On this, tab completion still works on my end. However, the API is a bit polluted now.

>>> import pysal
>>> dir(pysal)
['__builtins__',
 '__cached__',
 '__doc__',
 '__file__',
 '__loader__',
 '__name__',
 '__package__',
 '__path__',
 '__spec__',
 '__version__',
 'base', # this is new, not in the hierarchy
 'explore',
 'federation_hierarchy', # this is also new
 'lib',
 'memberships', # This is also new
 'model',
 'versions', # this is also new
 'viz']

I'd think versions could be amalgamated into the __version__ attribute, or alternatively __subpackage_versions__, with federation_hierarchy and memberships staying in base. Is this possible?

@sjsrey
Copy link
Member Author

sjsrey commented Jul 14, 2020

After a bit more introspection, the tab completion is a little awkward for the layers. It works fine for the packages once they're imported from the layers, but there is a bit of a lag completing on the layer name. In addition it does pollute the namespace so I think we can roll back for now and revisit it after the 2.3 release.

@@ -20,6 +20,7 @@
'pointpats': 'explore',
'inequality': 'explore',
'spaghetti': 'explore',
'access': 'access',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 'access': 'model',?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - good catch!

@sjsrey
Copy link
Member Author

sjsrey commented Jul 25, 2020

Replacing this with #1189

@sjsrey sjsrey closed this Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants