Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test coverage to 98% on network #613

Merged
merged 3 commits into from
May 21, 2015
Merged

Conversation

jlaura
Copy link
Member

@jlaura jlaura commented May 21, 2015

This is just on network.py. Tests are running in ~14 seconds for this module. The test case is the same as geodanet.

Updated coverage information:

$ nosetests --with-coverage --cover-package=pysal.network
.............
Name                     Stmts   Miss  Cover   Missing
------------------------------------------------------
pysal.network                1      0   100%
pysal.network.analysis     103     85    17%   10-30, 33-34, 37-41, 44-47, 59-64, 67-76, 85-94, 97-106, 117-125, 128-134, 137-144, 147-158, 174-186
pysal.network.network      495     12    98%   271, 278, 286, 692-694, 1065, 1069, 1129, 1163, 1166-1167
pysal.network.util          97     41    58%   13-30, 79-83, 130-138, 141-158
------------------------------------------------------
TOTAL                      696    138    80%
----------------------------------------------------------------------
Ran 13 tests in 13.383s

@coveralls
Copy link

Coverage Status

Coverage increased (+1.54%) to 85.81% when pulling bbd0e41 on jlaura:network_docs into 43babec on pysal:network_docs.

@dfolch
Copy link
Member

dfolch commented May 21, 2015

Is from __future__ import division needed for the tests to pass? Will this mess with the 2 to 3 conversion work that is being done separately?

@jlaura
Copy link
Member Author

jlaura commented May 21, 2015

That import is 2/3 compatible and is required to make the division behave the same.

@jlaura
Copy link
Member Author

jlaura commented May 21, 2015

The PR has been updated with 100% code coverage on network/utils. A few notes:

  • using a relative import because I am 100% sure that the tests will always live within the network directory
  • removed a lot of unused code from utils to avoid redundant testing
  • taking ~ 14 seconds on my box

@coveralls
Copy link

Coverage Status

Coverage increased (+1.69%) to 85.97% when pulling 29c902d on jlaura:network_docs into 43babec on pysal:network_docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.69%) to 85.97% when pulling 29c902d on jlaura:network_docs into 43babec on pysal:network_docs.

dfolch added a commit that referenced this pull request May 21, 2015
test coverage to 98% on network
@dfolch dfolch merged commit 7110407 into pysal:network_docs May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants