Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding explicit check for random region contiguity #620

Merged
merged 1 commit into from
Jun 8, 2015
Merged

adding explicit check for random region contiguity #620

merged 1 commit into from
Jun 8, 2015

Conversation

dfolch
Copy link
Member

@dfolch dfolch commented Jun 8, 2015

This will fix #617.

  • Added an explicit check for region contiguity using pysal.region.components.check_contiguity() function.
  • Added contiguity tests to test_randomregion.py.
  • Changed the doctests to rook contiguity, which makes the regions look nicer, but increases the time to run them.

sjsrey added a commit that referenced this pull request Jun 8, 2015
@sjsrey
Merge pull request #620 from dfolch/rr_bugfix
0eafed7 
adding explicit check for random region contiguity
@sjsrey sjsrey merged commit 0eafed7 into pysal:master Jun 8, 2015
@dfolch dfolch deleted the rr_bugfix branch June 8, 2015 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random_Region not respecting contiguity constraint
2 participants
@dfolch @sjsrey