allows non-symmetric distance matrices #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaura
added a commit
that referenced
this pull request
Jun 20, 2015
allows non-symmetric distance matrices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #633
For clearly symmetric distance matrices (i.e., when
destpattern=None) it only computes the upper triangle, and then mirrors that to the lower triangle. For all other point pattern pairs, the full distance matrix is computed, including the mxn case.Note: this PR currently follows the existing code by putting NAN along the diagonal of symmetric matrices. Should this be changed to zero?