ESDA Tabular Functions #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"exta" should have been "extra." once changed, the screen function needed slight modification to work with the rest of the pattern.
The grid was constructed using np.meshgrid over the range of the bounding box, with a computed stride. If the range and number of divisions were both integer, as was the case in the unittest, this generated floor division incorrectly. When we did initial testing in python3, we thought the unittest was correct. In fact, the unittest was incorrect, and we needed to enforce float division always.
Note that these comparators are NOT OGC-SPEC.
|
sorry, looks like there's some cruft from my pivot to the computational geometry stuff that snuck in, like will need to remove it before merging. |
|
OK, I think this is ready for review. |
This was referenced Jul 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is the work I've done to get tabular functions into esda. I'd hoped to at least submit this before going off into the rest of the project on the computational geometry stuff. Like before, here's the overview notebook.
A few things:
by_colmethods out from the classes proved to be too difficult. In some cases, there would have been specialby_colfunctions with dispatch on the input type, like forAge_Adjusted_Smoother. So, I just added them as class methods & added unittesting by class.