Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Correction to NetworkK formulation #470

Closed
jGaboardi opened this issue Apr 13, 2020 · 2 comments
Closed

[BUG] Correction to NetworkK formulation #470

jGaboardi opened this issue Apr 13, 2020 · 2 comments
Assignees
@jGaboardi
Labels
bug network stats priority-high
Milestone
Release v1.5.0

Comments

@jGaboardi
Copy link
Member

The current implementation is based on O’Sullivan and Unwin (2010), which should be formulated as follows:

equation 5.8, page 135

However, the total count variable is missing from the denominator

spaghetti/spaghetti/analysis.py

Line 224 in 73408ff

y *= intensity ** -1
resulting in:

  • D. O’Sullivan and D. J. Unwin. Point Pattern Analysis, chapter 5, pages 121–156. John Wiley & Sons, Ltd, 2010. doi:10.1002/9780470549094.ch5.

See also #469
@jGaboardi jGaboardi added this to the Release v1.5.0 milestone Apr 13, 2020
@jGaboardi jGaboardi self-assigned this Apr 13, 2020
@jGaboardi jGaboardi reopened this Apr 13, 2020
@jGaboardi jGaboardi mentioned this issue Apr 13, 2020
Merged
@jGaboardi
Copy link
Member Author

#471

@jGaboardi jGaboardi mentioned this issue Apr 13, 2020
Closed
12 tasks
@jGaboardi
Copy link
Member Author

@sjsrey I accidentally merged this, but going to leave it as it.

@jGaboardi jGaboardi mentioned this issue Apr 17, 2020
Merged
@jGaboardi jGaboardi mentioned this issue Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
bug network stats priority-high
Projects
None yet
Milestone
Release v1.5.0
Development

No branches or pull requests
1 participant
@jGaboardi