Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

310-no-optional CI failures [2024-03-16] #763

Closed
jGaboardi opened this issue Mar 16, 2024 · 0 comments · Fixed by #764
Closed

310-no-optional CI failures [2024-03-16] #763

jGaboardi opened this issue Mar 16, 2024 · 0 comments · Fixed by #764
Assignees
Labels
dependencies Pull requests that update a dependency file requirements

Comments

@jGaboardi
Copy link
Member

Current failures in 310-no-optional seem to come through esda from libpysal.

ImportError while importing test module '/home/runner/work/spaghetti/spaghetti/spaghetti/__init__.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../micromamba/envs/test/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
spaghetti/__init__.py:8: in <module>
    from .network import (
spaghetti/network.py:11: in <module>
    import esda
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/__init__.py:10: in <module>
    from . import adbscan, shape  # noqa F401
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/adbscan.py:12: in <module>
    from libpysal.cg.alpha_shapes import alpha_shape_auto
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/__init__.py:23: in <module>
    from . import cg
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/__init__.py:7: in <module>
    from .kdtree import *
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/kdtree.py:9: in <module>
    from scipy import inf
E   ImportError: cannot import name 'inf' from 'scipy' (/home/runner/micromamba/envs/test/lib/python3.10/site-packages/scipy/__init__.py)
ImportError while importing test module '/home/runner/work/spaghetti/spaghetti/spaghetti/__init__.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../micromamba/envs/test/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
spaghetti/__init__.py:8: in <module>
    from .network import (
spaghetti/network.py:11: in <module>
    import esda
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/__init__.py:10: in <module>
    from . import adbscan, shape  # noqa F401
../../../micromamba/envs/test/lib/python3.10/site-packages/esda/adbscan.py:12: in <module>
    from libpysal.cg.alpha_shapes import alpha_shape_auto
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/__init__.py:23: in <module>
    from . import cg
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/__init__.py:7: in <module>
    from .kdtree import *
../../../micromamba/envs/test/lib/python3.10/site-packages/libpysal/cg/kdtree.py:9: in <module>
    from scipy import inf
E   ImportError: cannot import name 'inf' from 'scipy' (/home/runner/micromamba/envs/test/lib/python3.10/site-packages/scipy/__init__.py)

It seems that the "no optional" is causing the issue in version deps. Since (1) geopandas and shapely have been hard reqs since libpysal==4.8.0. It's probably time to drop the "optional" regrading them.

@jGaboardi jGaboardi added requirements dependencies Pull requests that update a dependency file labels Mar 16, 2024
@jGaboardi jGaboardi self-assigned this Mar 16, 2024
jGaboardi added a commit that referenced this issue Mar 24, 2024
* RLS: v1.7.5.post1

* update pre-commit

* remove no-optional -- add GPD & SHP are hard reqs

* minor ruff linting

* GPD/SHP hard req in README

* forgot to remove no-opt yaml - proper shp pin

* proper gpd pin

* polish required imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant