Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting unit typos and errors in notebooks #528

Merged
merged 1 commit into from Oct 5, 2020
Merged

Correcting unit typos and errors in notebooks #528

merged 1 commit into from Oct 5, 2020

Conversation

jGaboardi
Copy link
Member

This PR addresses #525 in addition to:

  • incorrectly labeled units in the untransformed geodanet/streets.shp (meters --> feet) in some notebooks
  • incorrectly transformed units from geodanet/streets.shp ("epsg:2223" --> "esri:102649") in some notebooks
  • incorrectly scaled ScaleBar in some notebooks

@jGaboardi jGaboardi added this to the Release v1.6.0 milestone Oct 5, 2020
@jGaboardi jGaboardi self-assigned this Oct 5, 2020
@jGaboardi jGaboardi added this to In progress in JOSS paper Oct 5, 2020
@jGaboardi jGaboardi merged commit 7599e35 into pysal:master Oct 5, 2020
@jGaboardi jGaboardi deleted the split_typ0 branch October 5, 2020 23:11
@jGaboardi jGaboardi moved this from In progress to Done in JOSS paper Oct 5, 2020
@jGaboardi jGaboardi mentioned this pull request Oct 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jGaboardi jGaboardi

Labels
bug hacktoberfest-accepted notebooks rough edge
Projects
No open projects
JOSS paper
  
Done
Milestone
Release v1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jGaboardi