Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documentation for Network._extractnetwork() #534

Merged
merged 6 commits into from Oct 10, 2020

Conversation

jGaboardi
Copy link
Member

This PR:

@jGaboardi
Copy link
Member Author

jGaboardi commented Oct 10, 2020

Two issues here:

  • there is an issue with fiona upstream causing failures
=========================== short test summary info ===========================
542 ERROR spaghetti/__init__.py - AttributeError: module 'fiona' has no attribute...
543 ERROR spaghetti/network.py - AttributeError: module 'fiona' has no attribute ...
544 ERROR spaghetti/util.py - AttributeError: module 'fiona' has no attribute '_l...
545 ERROR spaghetti/tests/__init__.py - AttributeError: module 'fiona' has no att...
546 ERROR spaghetti/tests/network_unittest_classes.py - AttributeError: module 'f...
547 ERROR spaghetti/tests/test_api_network.py - AttributeError: module 'fiona' ha...
548 ERROR spaghetti/tests/test_api_network.py - AttributeError: module 'fiona' ha...
549 ERROR spaghetti/tests/test_dev_network.py - AttributeError: module 'fiona' ha...
550 ERROR spaghetti/tests/test_dev_network.py - AttributeError: module 'fiona' ha...
551 !!!!!!!!!!!!!!!!!!! Interrupted: 9 errors during collection !!!!!!!!!!!!!!!!!!!
============================== 9 errors in 4.23s ==============================
  • the new https://numpy.org/doc/stable/ seems to be down, so docs can't be rebuilt
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://numpy.org/doc/stable/objects.inv' not fetchable due to 
<class 'requests.exceptions.ConnectionError'>: 
('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

@jGaboardi
Copy link
Member Author

Going ahead with merge due to failure caused by fiona.

@jGaboardi jGaboardi merged commit 8dfec40 into pysal:master Oct 10, 2020
@jGaboardi jGaboardi deleted the explain_extractnet branch October 10, 2020 22:28
@jGaboardi jGaboardi moved this from In progress to Done in JOSS paper Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
JOSS paper
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant