Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt Python 3.10 in CI #657

Merged
merged 8 commits into from Dec 24, 2021
Merged

attempt Python 3.10 in CI #657

merged 8 commits into from Dec 24, 2021

Conversation

jGaboardi
Copy link
Member

This PR is an initial attempt at adding Python 3.10 to the GHA CI workflow.

@jGaboardi jGaboardi self-assigned this Dec 23, 2021
@jGaboardi jGaboardi added the ci label Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #657 (a5673b9) into main (2c88638) will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #657     +/-   ##
=======================================
+ Coverage   97.4%   97.6%   +0.2%     
=======================================
  Files          3       3             
  Lines       1174    1174             
  Branches     293     300      +7     
=======================================
+ Hits        1144    1146      +2     
+ Misses         8       7      -1     
+ Partials      22      21      -1     
Impacted Files Coverage Δ
spaghetti/network.py 97.4% <0.0%> (+0.2%) ⬆️

@martinfleis
Copy link
Member

Looks good.

Just a question - do we need to test all python versions on all OSs? Could we maybe slim it a bit similarly to what we've done in pysal/mapclassify#120?

@jGaboardi
Copy link
Member Author

Looks good.

Just a question - do we need to test all python versions on all OSs? Could we maybe slim it a bit similarly to what we've done in pysal/mapclassify#120?

Good idea.

@jGaboardi jGaboardi merged commit f10f9d0 into pysal:main Dec 24, 2021
@jGaboardi jGaboardi deleted the try_310 branch December 24, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants