Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setup.py so files are installed with "pip install ." #16

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

slumnitz
Copy link
Member

  • changed the version number to remove a warning
  • removed 2to3 build command that is no longer needed
  • added "splot" to package list so files in the package are included when installing with pip.

The problem here (pysal/esda#19) was that only dummy files got installed:

(master) $ python setup.py sdist
/Users/steffie/anaconda3/envs/gsoc/lib/python3.6/site-packages/setuptools/dist.py:388: UserWarning: Normalizing '1.0.0dev' to '1.0.0.dev0'
  normalized_version,
running sdist
running egg_info
creating splot.egg-info
writing splot.egg-info/PKG-INFO
writing dependency_links to splot.egg-info/dependency_links.txt
writing requirements to splot.egg-info/requires.txt
writing top-level names to splot.egg-info/top_level.txt
writing manifest file 'splot.egg-info/SOURCES.txt'
reading manifest file 'splot.egg-info/SOURCES.txt'
writing manifest file 'splot.egg-info/SOURCES.txt'
running check
creating splot-1.0.0.dev0
creating splot-1.0.0.dev0/splot.egg-info
copying files to splot-1.0.0.dev0...
copying README.rst -> splot-1.0.0.dev0
copying setup.py -> splot-1.0.0.dev0
copying splot.egg-info/PKG-INFO -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/SOURCES.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/dependency_links.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/not-zip-safe -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/requires.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/top_level.txt -> splot-1.0.0.dev0/splot.egg-info
Writing splot-1.0.0.dev0/setup.cfg
creating dist
Creating tar archive
removing 'splot-1.0.0.dev0' (and everything under it)

Now it installs all the files:

(master) $ git checkout fix-setuppy
Switched to branch 'fix-setuppy'

(fix-setuppy) $ python setup.py sdist
running sdist
running egg_info
writing splot.egg-info/PKG-INFO
writing dependency_links to splot.egg-info/dependency_links.txt
writing requirements to splot.egg-info/requires.txt
writing top-level names to splot.egg-info/top_level.txt
reading manifest file 'splot.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'splot.egg-info/SOURCES.txt'
running check
creating splot-1.0.0.dev0
creating splot-1.0.0.dev0/splot
creating splot-1.0.0.dev0/splot.egg-info
creating splot-1.0.0.dev0/splot/tests
copying files to splot-1.0.0.dev0...
copying MANIFEST.in -> splot-1.0.0.dev0
copying README.rst -> splot-1.0.0.dev0
copying setup.py -> splot-1.0.0.dev0
copying splot/__init__.py -> splot-1.0.0.dev0/splot
copying splot/_viz_bokeh.py -> splot-1.0.0.dev0/splot
copying splot/_viz_esda_mpl.py -> splot-1.0.0.dev0/splot
copying splot/_viz_giddy_mpl.py -> splot-1.0.0.dev0/splot
copying splot/_viz_utils.py -> splot-1.0.0.dev0/splot
copying splot/bk.py -> splot-1.0.0.dev0/splot
copying splot/color.py -> splot-1.0.0.dev0/splot
copying splot/esda.py -> splot-1.0.0.dev0/splot
copying splot/folium_mapping.py -> splot-1.0.0.dev0/splot
copying splot/giddy.py -> splot-1.0.0.dev0/splot
copying splot/mapping.py -> splot-1.0.0.dev0/splot
copying splot.egg-info/PKG-INFO -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/SOURCES.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/dependency_links.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/not-zip-safe -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/requires.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot.egg-info/top_level.txt -> splot-1.0.0.dev0/splot.egg-info
copying splot/tests/test_viz_bokeh.py -> splot-1.0.0.dev0/splot/tests
copying splot/tests/test_viz_esda_mpl.py -> splot-1.0.0.dev0/splot/tests
copying splot/tests/test_viz_giddy_mpl.py -> splot-1.0.0.dev0/splot/tests
Writing splot-1.0.0.dev0/setup.cfg
Creating tar archive
removing 'splot-1.0.0.dev0' (and everything under it)

change the version number to remove a warning
remove 2to3 build command that is no longer needed
add "splot" to package list so files in the package are included
when installing with pip.
@ljwolf
Copy link
Member

ljwolf commented Jun 28, 2018

Ah, yes, that packages option is necessary to identify what pip thinks it's packaging. Good catch.

@ljwolf ljwolf merged commit e73f1a1 into pysal:master Jun 28, 2018
@slumnitz slumnitz deleted the fix-setuppy branch June 30, 2018 00:56
@slumnitz slumnitz added this to Done in GSoC 2018 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
GSoC 2018
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants