add pysal integration/import test #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
reviewed
Jan 5, 2020
| sac1 = geopandas.read_file(sac1.get_path("sacramentot2.shp")) | ||
| sac2 = geopandas.read_file(sac2.get_path("SacramentoMSA2.shp")) | ||
|
|
||
| return sac1, sac2 |
There was a problem hiding this comment.
Should this return the raster so tests have it?
There was a problem hiding this comment.
the functions just use the path, so all it needs to do is check whether a raster is available at that location and it will be available when necessary
sjsrey
reviewed
Jan 5, 2020
| sac1 = geopandas.read_file(sac1.get_path("sacramentot2.shp")) | ||
| sac2 = geopandas.read_file(sac2.get_path("SacramentoMSA2.shp")) | ||
|
|
||
| return sac1, sac2 |
us os.path.join insted of hardcoded slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during pysal metapackage integration, we only need to test that the packages import, so this adds a simple test that does so.
this means we can skip the actual (long running) tests during pysal integration, as they are already run on the subpackages