Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying path for quilt storage #59

Merged
merged 9 commits into from
Mar 4, 2020

Conversation

knaaptime
Copy link
Member

the default storage path works fine for most applications but fails on travis. This allows a user to specify a download location where the quilt package, which should make it easier to solve issues like these https://travis-ci.org/knaaptime/geosnap/jobs/653970124?utm_medium=notification&utm_source=email

@knaaptime
Copy link
Member Author

🙄 I guess I'll revert this.

the issue is we need to provide a path to the NLCD raster. Installing the quilt package ensures that the raster is downloaded to the system, but quilt cant seem to find the path--i'm not sure why.

Nothing is actually broken, so i can revert this and handle the tests differently, but this also means I'd need to write some additional code for, e.g. https://github.com/spatialucr/geosnap-guide because we test those notebooks on travis.

ideally i'd like to avoid that, and only have the "canonical" example in those notebooks, but whatever

notebook no longer executes directly

@knaaptime knaaptime merged commit 52509a0 into pysal:master Mar 4, 2020
@knaaptime knaaptime deleted the quiltpath branch March 4, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant