Remove cython from runtime dependencies #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
added a commit
to galaxybot/galaxy
that referenced
this pull request
May 7, 2023
which mistakenly added Cython to its runtime dependencies. Will be fixed by pysam-developers/pysam#1186 .
This was referenced Jun 4, 2023
|
Ping @jmarshall @AndreasHeger , this affects also some bioconda recipes linked above. |
|
In order to benefit from this fix, there would also need to be a new point release made. This is @AndreasHeger's department, so there is no need to ping me. If this is causing trouble for bioconda, they have the option of patching their package themselves. |
It's only needed at build time. Fix build-time dependency versions: 0.29.12 accounted for CPython 3.8's PyCode_New() signature change and is as listed in setup.py; pysam does work with Cython 3.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only needed at build time.
Should fix https://github.com/galaxyproject/galaxy/pull/15942/files#r1167475501