-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Try using anaconda to run travis tests on OSX #234
Conversation
@AndreasHeger this almost works. If you look deeply in the OSX logs, the tests are actually failing due to linker import errors similar to what I found in #231 |
|
I think I fixed the linker problem on OS X in PR #233. |
I just merged in your changes but still see linker issues here: https://travis-ci.org/pysam-developers/pysam/jobs/111003944 |
My changes only fixed the linker problem under Python 3.5. It looks like you're using Python 3.3. I also saw linker failures on Python 3.4 using that approach and was unable to spend anymore time to track them down. Any chance you can try with Python 3.5? |
n/m. I see that Travis is testing multiple versions. |
When I get home tonight I'll look through your PR to see if I can figure anything else out. |
Good news is that Python 3.5 worked. Check out these lines in setup.py: if IS_PYTHON3:
import sysconfig
if sys.version_info.minor >= 5:
internal_htslib_libraries = ["chtslib.{}".format(
sysconfig.get_config_var('SOABI'))]
else:
# KBJ: This doesn't work for me on OS X with Python 3.4. Libs have no platform tags.
internal_htslib_libraries = ["chtslib.{}{}".format(
sys.implementation.cache_tag,
sys.abiflags)]
else:
internal_htslib_libraries = ["chtslib"] |
Actually, even the ones that "appear" to work are having some LD library path issues that I'll fix later---probably just need to set environment variables. For example, py35 on OSX: https://travis-ci.org/pysam-developers/pysam/jobs/111003946:L2484#L2530 |
FWIW, it's probably a bug in our CI if linker errors are happening silently and still giving green lights on Travis... |
Actually, the current build for linux has some test failures that could be related to your latest commits:
|
Note that the build has nosetest failures but still reports travis success, which is not quite right either... |
Thanks. Seems I broke the unit tests on travis. |
Almost there: with the latest changes from master, I'm down to the following:
|
Thanks, this is down to me. I will fix it tonight and merge. Best wishes, On 24/02/16 01:07, Kyle Beauchamp wrote:
|
Actually i still need to fix a few more issues with osx before merging this.
|
OK, I disabled libcurl on travis and it now seems to build OK on OSX. There are still some test failures, however, similar to what I show below.
|
Actually, there are build issues on py3K python versions on OSX. Py27 builds fine but dies during tests.
|
Thanks. I will check for open without close cases. |
Thanks! As all linux tests pass, I will now merge and comment out the osx section to be fixed in a separate branch. |
[WIP] Try using anaconda to run travis tests on OSX
Sounds good. Note that I also added the bioconda recipe to this pull request. I figured I might as well try to get that working as well. |
PS: if you open a [WIP] pull request with your OSX branch, I can try to comment on any travis failures that you see. |
No description provided.