Expose VCF classes #963
Merged
Expose VCF classes #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmarshall or @AndreasHeger I'd appreciate a review, or a pointer to a maintainer to review. I am open for reducing the # of exposed classes. |
|
I'm the original developer and fully support this change. I've wanted to add better class documentation and static typing, but spare time is just so limited. Thanks for your contribution and I'll commit to reviewing any future PRs. |
kevinjacobs-progenity
approved these changes
Oct 30, 2020
|
Thank you! I’ll make follow on PRs once I start using the types of I see anything. Thank you for the Friday PR review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extremely useful and important when we want to use the typing library. For example, I have a lot of methods that pass around a
VariantRecordSamplebut I am unable to annotate the type since the class is not able to be referenced.