-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-RC updates #1159
Merged
Merged
Pre-RC updates #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the issue forms to be up to current standards.
Updated the pull request template to include all current check items.
Updated the CI yamls to be better formatted and contain the new coveralls logic.
Updated code of conduct to comply with style standards.
Updated contributing guidelines to include better formatting and recent updates to style.
Updated readme to include better installation instructions.
Removed the old citation file.
Fixed the metadata implementation and used the resources package where possible.
Updated the manifest to not include old files.
Updated requirements to: - not include scipy (not imported anywhere), and - move pytest to the test installation.
Address a TODO for closed issue #988, which should fix updating the data without separate calls for xarray or pandas type.
This reverts commit be88ed7.
Updated the citation version and year.
Use the resources module to access the citation file, if possible.
Use the new module citation attribute.
Re-add the citation text file to the manifest.
Re-added the pytest requirement to the main code.
Fixed a bug in the xarray setitem magic method that did not account for native dimensions in the data when assigning arrays as values.
2 tasks
2 tasks
Found where scipy was needed, re-adding dependency.
Fixed a bug in assigning new xarray data.
jklenzing
reviewed
Nov 29, 2023
jklenzing
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1155 by comparing the package documents and tests to the ecosystem templates. Also:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit tests locally. Also:
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release