-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated pysat branch used by Travis #14
Conversation
Updated Travis CI to use 3.0.0 RC branch of pysat.
Updated the Instrument unit test setup to use params.
@@ -36,7 +36,7 @@ install: | |||
- pip install pysatCDF >/dev/null | |||
# Custom pysat install | |||
- cd .. | |||
- git clone --single-branch --branch develop-3 https://github.com/pysat/pysat.git | |||
- git clone --single-branch --branch v3-0-rc1 https://github.com/pysat/pysat.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- git clone --single-branch --branch v3-0-rc1 https://github.com/pysat/pysat.git | |
- git clone --single-branch --branch main https://github.com/pysat/pysat.git |
@@ -36,7 +36,7 @@ install: | |||
- pip install pysatCDF >/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pip install pysatCDF >/dev/null |
Looks like we need to merge this in for the updates to test_instruments.py before other work can be done. Should we update to Github Actions here or save that for a separate pull? @aburrell? |
Either way is ok for me. Let's just not remove the doc tests from travis until they are also in GitHub actions. |
@rstoneback, since this is holding up your branches, it's up to you. |
I'm fine either way. I figured out there is still a bit more work on incorporating version into the filename to ensure there are no mixed data loads. Plus I'm guessing the xarray transition (separate pull) will take some time. I don't know how long the testing transition will take but I think I'll take longer :) |
I've gone ahead and opened #20 as a replacement branch for this one. No docs yet, so documentation testing is not run here. However, a candidate workflow for doc testing is available in pysat/pysatSpaceWeather#47. |
Closing since #20 is merged |
Updated Travis CI to use 3.0.0 RC branch of pysat. Addresses pysat/pysat#676, and may be updated further once the pysat PR is closed.