-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Updated cosmic_gps to use public download option #17
Conversation
@jklenzing - I believe there was some discussion about the sub-directory structure at one point. For this pull, I updated things to be |
Requires #14 first |
I think this should work. As I recall, the . Was giving me trouble |
I also tried to update the format_str to include parsing the year and day from the leading directories but that didn't work. It doesn't like leading or trailing keywords. |
Tested new file listing function on my machine with a bunch of GPS files.
|
# Conflicts: # .travis.yml
84.5% coverage! 👀 |
level-2 files are in. Turns out there are a whole host of level-1 files as well. For after lunch. |
Long lunch but I've expanded support to latest level-2 and level-1 files. I left out files with unknown type or content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Data loads and downloads as expected. Fixing the "time mangling" of the uts time stamps is outside the scope here, but there should be something in the top-level docstring (either as a warning or a note) that uts is adjusted based on antenna number, etc.
Updates to time mangling are going to be handled in #18. I referenced your review note about the docstring over there. |
Addresses: #13, #1 (partial)
Updates
cosmic_gps
to use the new public data server from CDAAC instead of the option that required authentication. Also turns on tests forcosmic_gps
.The
format_str
for parsing cosmic file lists was updated to parse out the ground station, version, and satellite ID. The ground station and ID parameters used 'cycle' and 'revision' keyword parameters. I also switched from the delimited filename parsing to fixed width since not all extracted parameters have the appropriate delimiter.The check for duplicate times was updated to also performs a version check.
The time shift added to files is now constant for a given file, thus if a new version is released and downloaded, it will have the same time shift as the previous version, and will get filtered out by the version check.