New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc v0.3.2 #37
Rc v0.3.2 #37
Conversation
Made changes to comply with the new Meta standards, where labels are contained within the MetaLabels class.
adding a try/except to `_process_return_multi_z_attr` when decoding characters so that when uninterpretable characters are encountered, they are just replaced with some filler character but the user can still access the data.
adding comment to _cdf.py Co-authored-by: Russell Stoneback <rstoneba@utdallas.edu>
Update _cdf.py
Enable building extension on gfortran>=8
Bringing things up to date
RC4 and RC5 via testpypi are compiling and passing pysatNASA tests on my local system. The relevant command for testpypi download.
|
Co-authored-by: Jeff Klenzing <19592220+jklenzing@users.noreply.github.com>
Project Style Guidelines | ||
^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't formatting correctly for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing this is a GitHub Markdown peculiarity 🦥
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
||
--- | ||
|
||
**Describe the bug** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend using sections instead of boldface type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in other templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the note. I copied the templates from somewhere in our ecosystem. I don't remember from which package now though. Will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pysatMadrigal and pysatSpaceWeather have
# Description
A clear and concise description of what the bug is, including a description
of what you expected the outcome to be.
while the others, pysat, Models, Missions, Seasons, and CDAAC have the same here. I'll copy from Madrigal/SpaceWeather. Went a bit out of strict ** to # replacement, but the SpaceWeather/Madrigal versions are two whole years newer than the other packages.
CHANGELOG.md
Outdated
All notable changes to this project will be documented in this file. | ||
This project adheres to [Semantic Versioning](https://semver.org/). | ||
|
||
[0.3.2] - 2022-XX-XX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add a date.
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks everyone! |
Release Candidate for v0.3.2.
I intend to have a follow up release that increments the CDF library version. For highest backwards compatibility I decided to release this minimum changes version first.
Note the current version online for PIP only works for Mac systems. This release is intended to bring pysatCDF back from the dead. Rehabilitation and such will follow to further bring pysatCDF up to full project standards. Progress has been made in this release to add template docs, code formatting improved, etc. pysatCDF passes all tests via pysatNASA and is approx. 60 times faster loading CDF files than pure python.
Checklist:
CHANGELOG.md
, summarizing the changesoptional_pysatcdf
branch. Tests pass locally.)