Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc v0.3.2 #37

Merged
merged 76 commits into from May 12, 2022
Merged
Show file tree
Hide file tree
Changes from 68 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
e2507e5
STY: changed for introduction of MetaLabels
aburrell Dec 9, 2020
1cb2050
Update _cdf.py
gregstarr Jan 5, 2021
e3e441e
Apply suggestions from code review
gregstarr Jan 20, 2021
20de52e
Merge pull request #28 from gregstarr/develop
rstoneback Jan 21, 2021
8ab4b59
Enable building extension on gfortran>=8
asreimer Mar 12, 2021
a41d172
Merge pull request #31 from asreimer/develop
rstoneback Mar 12, 2021
da9d46a
Merge branch 'develop' into fixes
rstoneback Feb 18, 2022
f567598
TST: update for pysat3
rstoneback Feb 18, 2022
0c8cae2
TST: Removed python 2 testing
rstoneback Feb 18, 2022
3801e81
TST: Updated tests
rstoneback Feb 18, 2022
66e7a54
Merge pull request #32 from pysat/fixes
rstoneback Feb 18, 2022
3e4c11c
TST: Add test for `to_pysat()`
rstoneback Feb 18, 2022
19a4a18
DOC: Update branch for buttons
rstoneback Feb 18, 2022
6e47ace
TST: Workflows testing
rstoneback Feb 18, 2022
b10a59d
DOC: Add zenodo
rstoneback Feb 18, 2022
6b7b560
DOC: Templates
rstoneback Feb 18, 2022
14af64e
DOC: Doc build workflow
rstoneback Feb 18, 2022
62d04d0
STY: Shortened max line length
rstoneback Feb 18, 2022
b65706f
STY: flake8
rstoneback Feb 18, 2022
d09b431
STY: flake8
rstoneback Feb 18, 2022
436495a
STY: New setup
rstoneback Feb 18, 2022
c039121
STY: flake8
rstoneback Feb 18, 2022
01ba050
STY: flake8
rstoneback Feb 18, 2022
fc1ec67
STY: flake8
rstoneback Feb 18, 2022
6edcc78
STY: flake8
rstoneback Feb 18, 2022
1e6c981
STY: flake8
rstoneback Feb 18, 2022
146f0c2
TST: Try installing
rstoneback Feb 18, 2022
45366ed
TST: Proper input
rstoneback Feb 18, 2022
f06804f
STY: setup cleanup and correction
rstoneback Feb 18, 2022
5118705
TST: Remove MacOS, no fortran
rstoneback Feb 18, 2022
41b271b
TST: Remove Travis Testing
rstoneback Feb 18, 2022
80a14ef
STY: Update readme
rstoneback Feb 18, 2022
19a8d4c
STY: Update readme for Windows
rstoneback Feb 18, 2022
4a1f8cc
TST: Added tests for repr and data access
rstoneback Feb 18, 2022
2dbf0ad
STY: Data should always be loaded.
rstoneback Feb 18, 2022
fa511c9
STY: Update readme
rstoneback Feb 18, 2022
15213de
DOC: Add and update changelog
rstoneback Feb 18, 2022
c243bc9
STY: Updates per pysatModels #98
rstoneback Feb 23, 2022
92f1d76
BUG: Missing numpy_ver
rstoneback Feb 23, 2022
347fd20
Apply suggestions from code review
rstoneback Feb 24, 2022
86256bf
ENH: Added version per reviewer comment
rstoneback Feb 24, 2022
27c45e5
BUG: Fix init import and updated comments.
rstoneback Feb 24, 2022
990f142
BUG: Addressed meta issue
rstoneback Mar 8, 2022
31cd312
Update .github/workflows/main.yml
rstoneback Apr 26, 2022
ec9b495
Merge pull request #33 from pysat/fixes
rstoneback Apr 26, 2022
e1b6e17
STY: Update version
rstoneback Apr 27, 2022
92e01ef
STY: Update changelog
rstoneback Apr 27, 2022
c03ffaa
Merge branch 'main' into rc-0-3-2
rstoneback Apr 27, 2022
bf4938d
STY: Update zenodo author list
rstoneback Apr 28, 2022
1056e42
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback Apr 28, 2022
f7b21d9
STY: Comment cleanup setup.py
rstoneback Apr 28, 2022
1d594b1
STY: Update orcid
rstoneback Apr 29, 2022
a18512b
STY: Update changelog
rstoneback Apr 29, 2022
76d2836
STY: Corrected platform codes
rstoneback May 2, 2022
16144f7
STY: Format improvements
rstoneback May 2, 2022
1791551
STY: Format improvements
rstoneback May 2, 2022
c77f262
Apply suggestions from code review
rstoneback May 4, 2022
1ff00a2
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback May 4, 2022
9a10d97
ENH: Added contributing
rstoneback May 4, 2022
cb8fe77
STY: Reviewer comment
rstoneback May 4, 2022
07189ca
BUG: Add version.txt to manifest
rstoneback May 4, 2022
63daaa2
BUG: Moved contributing
rstoneback May 4, 2022
b6122f2
BUG: version.txt wasn't included with pip compiled code
rstoneback May 4, 2022
6f147dd
STY: . -> pysatCDF
rstoneback May 4, 2022
3f239de
STY: typo
rstoneback May 4, 2022
91e5ab7
Update CONTRIBUTING.md
rstoneback May 4, 2022
a640bf1
STY: Add logo
rstoneback May 5, 2022
8675415
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback May 5, 2022
3e66cf8
STY: Reviewer suggestion
rstoneback May 11, 2022
48a12e6
Apply suggestions from code review
rstoneback May 11, 2022
e0b9da1
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback May 11, 2022
85e8fe2
ENH: Drop it like its CDF
rstoneback May 11, 2022
c2381c6
STY: Added date
rstoneback May 11, 2022
a662114
STY: line length
rstoneback May 11, 2022
659901b
ENH: Copied latest bug_report and feature_request from pysatSpaceWeather
rstoneback May 11, 2022
0e1aa34
BUG: flake8
rstoneback May 11, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
@@ -0,0 +1,32 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

**Describe the bug**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend using sections instead of boldface type.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in other templates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note. I copied the templates from somewhere in our ecosystem. I don't remember from which package now though. Will update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pysatMadrigal and pysatSpaceWeather have

# Description
A clear and concise description of what the bug is, including a description
of what you expected the outcome to be.

while the others, pysat, Models, Missions, Seasons, and CDAAC have the same here. I'll copy from Madrigal/SpaceWeather. Went a bit out of strict ** to # replacement, but the SpaceWeather/Madrigal versions are two whole years newer than the other packages.

A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Version [e.g. 22]
- Other details about your setup that could be relevant

**Additional context**
Add any other context about the problem here.
20 changes: 20 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.
49 changes: 49 additions & 0 deletions .github/pull_request_template.md
@@ -0,0 +1,49 @@
# Description

Addresses #(issue)

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change. Please see ``CONTRIBUTING.md`` for more guidelines.
rstoneback marked this conversation as resolved.
Show resolved Hide resolved

## Type of change

Please delete options that are not relevant.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality
to not work as expected)
- This change requires a documentation update

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

- Test A
- Test B

**Test Configuration**:
* Operating system: Hal
* Version number: Python 3.X
* Any details about your local setup that are relevant: pysat version X

# Checklist:

- [ ] Make sure you are merging into the ``develop`` (not ``main``) branch
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] Add a note to ``CHANGELOG.md``, summarizing the changes
- [ ] Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release
32 changes: 32 additions & 0 deletions .github/workflows/docs.yml
@@ -0,0 +1,32 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Documentation Check

on: [push, pull_request]

jobs:
build:

runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [3.9]
rstoneback marked this conversation as resolved.
Show resolved Hide resolved

name: Documentation tests
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
rstoneback marked this conversation as resolved.
Show resolved Hide resolved
pip install -r test_requirements.txt
pip install -r requirements.txt

- name: Load .zenodo.json to check for errors
run: python -c "import json; json.loads(open('.zenodo.json').read())"
56 changes: 56 additions & 0 deletions .github/workflows/main.yml
@@ -0,0 +1,56 @@
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: Pytest with Flake8

on: [push, pull_request]

jobs:
build:
strategy:
fail-fast: false
matrix:
python-version: ["3.9", "3.10"]
os: [ubuntu-latest]
numpy_ver: [latest]
include:
- python-version: "3.8"
numpy_ver: "1.19"
os: "ubuntu-latest"

name: Python ${{ matrix.python-version }} on ${{ matrix.os }} with numpy ${{ matrix.numpy_ver }}
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: |
python -m pip install --upgrade pip
rstoneback marked this conversation as resolved.
Show resolved Hide resolved
pip install -r test_requirements.txt
pip install -r requirements.txt

- name: Install NEP29 dependencies
if: ${{ matrix.numpy_ver != 'latest'}}
run: |
pip install --no-binary :numpy: numpy==${{ matrix.numpy_ver }}

- name: Test PEP8 compliance
run: flake8 . --count --select=E,F,W --show-source --statistics

- name: Evaluate complexity
run: flake8 . --count --exit-zero --max-complexity=10 --statistics

- name: Install
run: python setup.py develop

- name: Test with pytest
run: pytest --cov=pysatCDF/

- name: Publish results to coveralls
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: coveralls --rcfile=setup.cfg --service=github
51 changes: 0 additions & 51 deletions .travis.yml

This file was deleted.

35 changes: 35 additions & 0 deletions .zenodo.json
@@ -0,0 +1,35 @@
{
"creators": [
{
"affiliation": "Stoneris",
"name": "Stoneback, Russell",
"orcid": "0000-0001-7216-4336"
},
{
"affiliation": "The University of Texas at Dallas",
"name": "Depew, Matthew"
},
{
"affiliation": "Goddard Space Flight Center",
"name": "Klenzing, Jeffrey",
"orcid": "0000-0001-8321-6074"
},
{
"name": "Iyer, Gayatri"
},
{
"affiliation": "Predictive Science",
"name": "Pembroke, Asher"
},
{
"affiliation": "The Johns Hopkins Applied Physics Laboratory",
"name": "Starr, Greg",
"orcid": "0000-0002-3487-3630"
},
{
"affiliation": "SRI International",
"name": "Reimer, Ashton",
"orcid": "0000-0002-4621-3453"
}
]
}
22 changes: 22 additions & 0 deletions CHANGELOG.md
@@ -0,0 +1,22 @@
Change Log
==========
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

[0.3.2] - 2022-XX-XX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a date.

--------------------
* New Features
* Compatible with pysat v3.0+
* Deprecations
* Documentation
* Added pull request templates and other GitHub project documentation.
* Switched Windows installation instructions to favor installing WSL.
* Bug Fix
* Improved builds for newer compilers.
* Replaces uninterpretable characters with '*' so data loading may continue.
* Maintenance
* Adopted latest pysat development standards.
* Shifted from TravisCI to GitHub Actions for online testing.
* Adopted setup.cfg
* Improved PEP8 compliance