New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc v0.3.2 #37
Merged
Merged
Rc v0.3.2 #37
Changes from 68 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
e2507e5
STY: changed for introduction of MetaLabels
aburrell 1cb2050
Update _cdf.py
gregstarr e3e441e
Apply suggestions from code review
gregstarr 20de52e
Merge pull request #28 from gregstarr/develop
rstoneback 8ab4b59
Enable building extension on gfortran>=8
asreimer a41d172
Merge pull request #31 from asreimer/develop
rstoneback da9d46a
Merge branch 'develop' into fixes
rstoneback f567598
TST: update for pysat3
rstoneback 0c8cae2
TST: Removed python 2 testing
rstoneback 3801e81
TST: Updated tests
rstoneback 66e7a54
Merge pull request #32 from pysat/fixes
rstoneback 3e4c11c
TST: Add test for `to_pysat()`
rstoneback 19a4a18
DOC: Update branch for buttons
rstoneback 6e47ace
TST: Workflows testing
rstoneback b10a59d
DOC: Add zenodo
rstoneback 6b7b560
DOC: Templates
rstoneback 14af64e
DOC: Doc build workflow
rstoneback 62d04d0
STY: Shortened max line length
rstoneback b65706f
STY: flake8
rstoneback d09b431
STY: flake8
rstoneback 436495a
STY: New setup
rstoneback c039121
STY: flake8
rstoneback 01ba050
STY: flake8
rstoneback fc1ec67
STY: flake8
rstoneback 6edcc78
STY: flake8
rstoneback 1e6c981
STY: flake8
rstoneback 146f0c2
TST: Try installing
rstoneback 45366ed
TST: Proper input
rstoneback f06804f
STY: setup cleanup and correction
rstoneback 5118705
TST: Remove MacOS, no fortran
rstoneback 41b271b
TST: Remove Travis Testing
rstoneback 80a14ef
STY: Update readme
rstoneback 19a8d4c
STY: Update readme for Windows
rstoneback 4a1f8cc
TST: Added tests for repr and data access
rstoneback 2dbf0ad
STY: Data should always be loaded.
rstoneback fa511c9
STY: Update readme
rstoneback 15213de
DOC: Add and update changelog
rstoneback c243bc9
STY: Updates per pysatModels #98
rstoneback 92f1d76
BUG: Missing numpy_ver
rstoneback 347fd20
Apply suggestions from code review
rstoneback 86256bf
ENH: Added version per reviewer comment
rstoneback 27c45e5
BUG: Fix init import and updated comments.
rstoneback 990f142
BUG: Addressed meta issue
rstoneback 31cd312
Update .github/workflows/main.yml
rstoneback ec9b495
Merge pull request #33 from pysat/fixes
rstoneback e1b6e17
STY: Update version
rstoneback 92e01ef
STY: Update changelog
rstoneback c03ffaa
Merge branch 'main' into rc-0-3-2
rstoneback bf4938d
STY: Update zenodo author list
rstoneback 1056e42
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback f7b21d9
STY: Comment cleanup setup.py
rstoneback 1d594b1
STY: Update orcid
rstoneback a18512b
STY: Update changelog
rstoneback 76d2836
STY: Corrected platform codes
rstoneback 16144f7
STY: Format improvements
rstoneback 1791551
STY: Format improvements
rstoneback c77f262
Apply suggestions from code review
rstoneback 1ff00a2
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback 9a10d97
ENH: Added contributing
rstoneback cb8fe77
STY: Reviewer comment
rstoneback 07189ca
BUG: Add version.txt to manifest
rstoneback 63daaa2
BUG: Moved contributing
rstoneback b6122f2
BUG: version.txt wasn't included with pip compiled code
rstoneback 6f147dd
STY: . -> pysatCDF
rstoneback 3f239de
STY: typo
rstoneback 91e5ab7
Update CONTRIBUTING.md
rstoneback a640bf1
STY: Add logo
rstoneback 8675415
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback 3e66cf8
STY: Reviewer suggestion
rstoneback 48a12e6
Apply suggestions from code review
rstoneback e0b9da1
Merge remote-tracking branch 'origin/rc-0-3-2' into rc-0-3-2
rstoneback 85e8fe2
ENH: Drop it like its CDF
rstoneback c2381c6
STY: Added date
rstoneback a662114
STY: line length
rstoneback 659901b
ENH: Copied latest bug_report and feature_request from pysatSpaceWeather
rstoneback 0e1aa34
BUG: flake8
rstoneback File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** | ||
Steps to reproduce the behavior: | ||
1. Go to '...' | ||
2. Click on '....' | ||
3. Scroll down to '....' | ||
4. See error | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
**Screenshots** | ||
If applicable, add screenshots to help explain your problem. | ||
|
||
**Desktop (please complete the following information):** | ||
- OS: [e.g. iOS] | ||
- Version [e.g. 22] | ||
- Other details about your setup that could be relevant | ||
|
||
**Additional context** | ||
Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: '' | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Description | ||
|
||
Addresses #(issue) | ||
|
||
Please include a summary of the change and which issue is fixed. Please also | ||
include relevant motivation and context. List any dependencies that are required | ||
for this change. Please see ``CONTRIBUTING.md`` for more guidelines. | ||
rstoneback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Type of change | ||
|
||
Please delete options that are not relevant. | ||
|
||
- Bug fix (non-breaking change which fixes an issue) | ||
- New feature (non-breaking change which adds functionality) | ||
- Breaking change (fix or feature that would cause existing functionality | ||
to not work as expected) | ||
- This change requires a documentation update | ||
|
||
# How Has This Been Tested? | ||
|
||
Please describe the tests that you ran to verify your changes. Provide | ||
instructions so we can reproduce. Please also list any relevant details for | ||
your test configuration | ||
|
||
- Test A | ||
- Test B | ||
|
||
**Test Configuration**: | ||
* Operating system: Hal | ||
* Version number: Python 3.X | ||
* Any details about your local setup that are relevant: pysat version X | ||
|
||
# Checklist: | ||
|
||
- [ ] Make sure you are merging into the ``develop`` (not ``main``) branch | ||
- [ ] My code follows the style guidelines of this project | ||
- [ ] I have performed a self-review of my own code | ||
- [ ] I have commented my code, particularly in hard-to-understand areas | ||
- [ ] I have made corresponding changes to the documentation | ||
- [ ] My changes generate no new warnings | ||
- [ ] I have added tests that prove my fix is effective or that my feature works | ||
- [ ] New and existing unit tests pass locally with my changes | ||
- [ ] Any dependent changes have been merged and published in downstream modules | ||
- [ ] Add a note to ``CHANGELOG.md``, summarizing the changes | ||
- [ ] Update zenodo.json file for new code contributors | ||
|
||
If this is a release PR, replace the first item of the above checklist with the | ||
release checklist on the pysat wiki: | ||
https://github.com/pysat/pysat/wiki/Checklist-for-Release |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions | ||
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
||
name: Documentation Check | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: [3.9] | ||
rstoneback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
name: Documentation tests | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
rstoneback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pip install -r test_requirements.txt | ||
pip install -r requirements.txt | ||
|
||
- name: Load .zenodo.json to check for errors | ||
run: python -c "import json; json.loads(open('.zenodo.json').read())" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# This workflow will install Python dependencies, run tests and lint with a variety of Python versions | ||
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
||
name: Pytest with Flake8 | ||
|
||
on: [push, pull_request] | ||
|
||
jobs: | ||
build: | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9", "3.10"] | ||
os: [ubuntu-latest] | ||
numpy_ver: [latest] | ||
include: | ||
- python-version: "3.8" | ||
numpy_ver: "1.19" | ||
os: "ubuntu-latest" | ||
|
||
name: Python ${{ matrix.python-version }} on ${{ matrix.os }} with numpy ${{ matrix.numpy_ver }} | ||
runs-on: ${{ matrix.os }} | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
rstoneback marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pip install -r test_requirements.txt | ||
pip install -r requirements.txt | ||
|
||
- name: Install NEP29 dependencies | ||
if: ${{ matrix.numpy_ver != 'latest'}} | ||
run: | | ||
pip install --no-binary :numpy: numpy==${{ matrix.numpy_ver }} | ||
|
||
- name: Test PEP8 compliance | ||
run: flake8 . --count --select=E,F,W --show-source --statistics | ||
|
||
- name: Evaluate complexity | ||
run: flake8 . --count --exit-zero --max-complexity=10 --statistics | ||
|
||
- name: Install | ||
run: python setup.py develop | ||
|
||
- name: Test with pytest | ||
run: pytest --cov=pysatCDF/ | ||
|
||
- name: Publish results to coveralls | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: coveralls --rcfile=setup.cfg --service=github |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"creators": [ | ||
{ | ||
"affiliation": "Stoneris", | ||
"name": "Stoneback, Russell", | ||
"orcid": "0000-0001-7216-4336" | ||
}, | ||
{ | ||
"affiliation": "The University of Texas at Dallas", | ||
"name": "Depew, Matthew" | ||
}, | ||
{ | ||
"affiliation": "Goddard Space Flight Center", | ||
"name": "Klenzing, Jeffrey", | ||
"orcid": "0000-0001-8321-6074" | ||
}, | ||
{ | ||
"name": "Iyer, Gayatri" | ||
}, | ||
{ | ||
"affiliation": "Predictive Science", | ||
"name": "Pembroke, Asher" | ||
}, | ||
{ | ||
"affiliation": "The Johns Hopkins Applied Physics Laboratory", | ||
"name": "Starr, Greg", | ||
"orcid": "0000-0002-3487-3630" | ||
}, | ||
{ | ||
"affiliation": "SRI International", | ||
"name": "Reimer, Ashton", | ||
"orcid": "0000-0002-4621-3453" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
Change Log | ||
========== | ||
All notable changes to this project will be documented in this file. | ||
This project adheres to [Semantic Versioning](https://semver.org/). | ||
|
||
[0.3.2] - 2022-XX-XX | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to add a date. |
||
-------------------- | ||
* New Features | ||
* Compatible with pysat v3.0+ | ||
* Deprecations | ||
* Documentation | ||
* Added pull request templates and other GitHub project documentation. | ||
* Switched Windows installation instructions to favor installing WSL. | ||
* Bug Fix | ||
* Improved builds for newer compilers. | ||
* Replaces uninterpretable characters with '*' so data loading may continue. | ||
* Maintenance | ||
* Adopted latest pysat development standards. | ||
* Shifted from TravisCI to GitHub Actions for online testing. | ||
* Adopted setup.cfg | ||
* Improved PEP8 compliance | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend using sections instead of boldface type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same in other templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the note. I copied the templates from somewhere in our ecosystem. I don't remember from which package now though. Will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pysatMadrigal and pysatSpaceWeather have
while the others, pysat, Models, Missions, Seasons, and CDAAC have the same here. I'll copy from Madrigal/SpaceWeather. Went a bit out of strict ** to # replacement, but the SpaceWeather/Madrigal versions are two whole years newer than the other packages.