Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: support user / password info in unit tests #29

Merged
merged 7 commits into from
Dec 14, 2020

Conversation

jklenzing
Copy link
Member

This PR works in conjunction with pysat/pysat#623. Allows user and email to be passed through the instruments in test_instruments.py for Madrigal database. Removes auto-generation of test values in the instrument methods.

Note this is expected to fail on Travis until changes at pysat are merged into develop-3. Passes locally with the pysat test branch.

@jklenzing jklenzing marked this pull request as ready for review December 11, 2020 17:50
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small documentation comment.

pysatMadrigal/instruments/methods/madrigal.py Outdated Show resolved Hide resolved
jklenzing and others added 2 commits December 14, 2020 12:31
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing
Copy link
Member Author

Updated docs and added a few temporary fixes to Travis so the tests will run. Anticipate that these will be surpassed by the changes in #31

@jklenzing jklenzing merged commit 2eac3fd into develop Dec 14, 2020
@jklenzing jklenzing deleted the tst/user-password branch December 14, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants