Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in remote file listing method #36

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Conversation

aburrell
Copy link
Member

This addresses #5 and also improves the style of the general instrument template, which will eventually be fixed up to address #1.

To test:

import datetime as dt
import pysat
import pysatMadrigal as py_mad

dmsp_f13 = pysat.Instrument(inst_module=py_mad.instruments.dmsp_ivm, tag='utd', inst_id='f13')
out = dmsp_f13._list_remote_files_rtn(dmsp_f13.tag, dmsp_f13.inst_id, user="Your Name", password="your@email", start=py_mad.instruments.dmsp_ivm._test_dates[dmsp_f13.inst_id][dmsp_f13.tag], stop=py_mad.instruments.dmsp_ivm._test_dates[dmsp_f13.inst_id][dmsp_f13.tag] + dt.timedelta(days=1))
print(out)

Yields

1997-12-31    dms_ut_19971231_13.002.hdf5
1998-01-01    dms_ut_19980101_13.002.hdf5
1998-01-02    dms_ut_19980102_13.002.hdf5
dtype: object

Fixed bug in remote file list, feeding pysat routines a list of filenames instead of a list of madrigal class objects.
Fixed the kindat input to better reflect pysatMadrigal Instrument structure.
Updated the madrigal Instruments by:
- making all the kindats strings,
- fixing docstrings,
- updating list_remote_file input, and
- fixing the template organization.
Updated Changelog with all recent improvements.
@aburrell aburrell added this to the 0.1.0 Release milestone Jan 21, 2021
Fixed flake8 issues, commenting out blocks that will take more work to make operational.
@jklenzing
Copy link
Member

This works locally for me for all but the oblique products from jro_isr.

I have a branch that incorporates this into unit tests, but it requires some quality of life upgrades at pysat. I can push those branches if you want to solve everything now. Or we can finish this one to fix dmsp and write up an issue for jro.

@aburrell
Copy link
Member Author

Second option!

@aburrell aburrell merged commit 79436c6 into develop Jan 25, 2021
@aburrell aburrell deleted the bug_remote_file_list branch January 25, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants