Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: GitHub actions #45

Merged
merged 23 commits into from
Mar 18, 2022
Merged

TST: GitHub actions #45

merged 23 commits into from
Mar 18, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented May 7, 2021

Addresses pysat/pysat#777. Replaces #44

  • Migrates CI tests to Github Actions
  • Updates requirements files and setup.cfg
  • Updates readme file now that pysat 3.0 is released

@jklenzing
Copy link
Member Author

The GPS instrument currently fails to load. Looking into to this more, but putting this up to link to in issues.

@jklenzing
Copy link
Member Author

Added a version cap for xarray and documented the bug in #46. Since the latest xarray is not yet in conda, the Travis CI tests do not catch this.

The one failing test is a result of download issues, likely a server hiccup. Opening for review.

@jklenzing jklenzing marked this pull request as ready for review May 10, 2021 16:07
@jklenzing
Copy link
Member Author

Added the macos tests for completeness.

.github/workflows/main.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
jklenzing and others added 2 commits May 10, 2021 13:06
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing jklenzing added this to the 0.0.4 Release milestone May 10, 2021
@jklenzing
Copy link
Member Author

@aburrell, I'm running into an issue where the remote server sometimes fails to send back a file. Sadly, github actions only has the option to rerun all jobs rather than a single failing job, which means it is highly likely that the server will fail again. Ran the latest versions of this several times last night, with the best case where only one job would fail.

This is on GA's radar, but no word as to when it will be fixed: actions/runner#432

@aburrell
Copy link
Member

This is on GA's radar, but no word as to when it will be fixed: actions/runner#432

Seems like the best course of action, for the moment, is to stick with Travis for this package. We can either close this PR and put an issue in specifying the branch with the work, or convert this to a draft and tag it as Future. Thoughts?

@jklenzing
Copy link
Member Author

I vote for converting this to a draft and flagging as future. We will need to fix #44 to get Travis CI working again.

@jklenzing jklenzing marked this pull request as draft May 11, 2021 14:50
@jklenzing jklenzing removed this from the 0.0.4 Release milestone May 11, 2021
@jklenzing jklenzing added this to the Future milestone May 11, 2021
@jklenzing
Copy link
Member Author

Merging from develop to keep this mostly current. Noting that the required changes to Github Actions now in the github roadmap for Q4 2021. github/roadmap#271

.github/workflows/main.yml Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@aburrell aburrell modified the milestones: Future, 0.1.0 Release Mar 17, 2022
Co-Authored-By: Angeline Burrell <aburrell@users.noreply.github.com>
@jklenzing jklenzing marked this pull request as ready for review March 18, 2022 14:52
@jklenzing jklenzing requested a review from aburrell March 18, 2022 14:53
@jklenzing
Copy link
Member Author

The "run failed jobs" tab works as expected. 2-3 failed the first time around due to server issues, but this allowed me to just rerun those jobs.

@jklenzing jklenzing merged commit ea8b2e3 into develop Mar 18, 2022
@jklenzing jklenzing deleted the tst/github_actions branch March 18, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants