-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: GitHub actions #45
Conversation
The GPS instrument currently fails to load. Looking into to this more, but putting this up to link to in issues. |
Added a version cap for xarray and documented the bug in #46. Since the latest xarray is not yet in conda, the Travis CI tests do not catch this. The one failing test is a result of download issues, likely a server hiccup. Opening for review. |
Added the macos tests for completeness. |
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@aburrell, I'm running into an issue where the remote server sometimes fails to send back a file. Sadly, github actions only has the option to rerun all jobs rather than a single failing job, which means it is highly likely that the server will fail again. Ran the latest versions of this several times last night, with the best case where only one job would fail. This is on GA's radar, but no word as to when it will be fixed: actions/runner#432 |
Seems like the best course of action, for the moment, is to stick with Travis for this package. We can either close this PR and put an issue in specifying the branch with the work, or convert this to a draft and tag it as Future. Thoughts? |
I vote for converting this to a draft and flagging as future. We will need to fix #44 to get Travis CI working again. |
Merging from develop to keep this mostly current. Noting that the required changes to Github Actions now in the github roadmap for Q4 2021. github/roadmap#271 |
Co-Authored-By: Angeline Burrell <aburrell@users.noreply.github.com>
The "run failed jobs" tab works as expected. 2-3 failed the first time around due to server issues, but this allowed me to just rerun those jobs. |
Addresses pysat/pysat#777. Replaces #44