Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netcdf4 update #47

Merged
merged 2 commits into from
May 10, 2021
Merged

Netcdf4 update #47

merged 2 commits into from
May 10, 2021

Conversation

aburrell
Copy link
Member

Fixes bug found in #46 by adding the missing kwarg to the NetCDF4 data loading calls.

Added missing kwarg `engine` to xarray load routines for NetCDF4 data.
Added summary of bugfix to the changelog.
@aburrell aburrell added this to the 0.0.4 Release milestone May 10, 2021
@aburrell aburrell added the bug Something isn't working label May 10, 2021
@aburrell aburrell requested a review from jklenzing May 10, 2021 16:49
@aburrell aburrell linked an issue May 10, 2021 that may be closed by this pull request
@jklenzing
Copy link
Member

Looks like this will work. Running tests locally...

Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally using pytest. Recommend we merge this in first, so I can pull the changes into #45 and remove the version cap there.

@aburrell aburrell merged commit a35dc4b into develop May 10, 2021
@aburrell aburrell deleted the netcdf4_update branch May 10, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: gnss_tec cannot load for xarray 0.18.0
2 participants