Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysat 3.0 release preperation #44

Closed
wants to merge 13 commits into from
Closed

pysat 3.0 release preperation #44

wants to merge 13 commits into from

Conversation

jklenzing
Copy link
Member

Description

Addresses #pysat/pysat#676

Updates tests to use release candidate.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

via travis CI

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing
Copy link
Member Author

@aburrell , I'm having issues installing apexpy under the travis environment with numpy 1.19.2. I've tried the suggestion from the apexpy site to use pip install --no-binary :apexpy: apexpy, but travis seems to have issues with this.

I've tried setting up an alternate environment using github actions (#45). The install environment works there, but would require some changes under pysat to get the directory setup to work properly.

@aburrell
Copy link
Member

Ok, I checked the apexpy travis and it looks like its using numpy 1.19.5. Very confused. What happens if you grab apexpy from github (to see if it's a package issue or a pypi-apexpy combo issue).

@jklenzing
Copy link
Member Author

It seems to be a numpy issue. It compiles if I use numpy 1.20, checking other versions now. The latest version conda has is 1.19.2, which does not work.

@jklenzing
Copy link
Member Author

Ok, I checked the apexpy travis and it looks like its using numpy 1.19.5. Very confused. What happens if you grab apexpy from github (to see if it's a package issue or a pypi-apexpy combo issue).

Installing apexpy by cloning from github works.

@jklenzing
Copy link
Member Author

Linking to #45 (github actions version) and #46 (manual install of apexpy) for discussion

@jklenzing
Copy link
Member Author

Closing in favor of #47

@jklenzing jklenzing closed this Apr 27, 2021
@jklenzing jklenzing deleted the jklenzing-patch-2 branch August 11, 2021 18:19
@jklenzing jklenzing mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants