Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST/MAINT: update to pysat 3.0.0 standards, github actions #47

Merged
merged 14 commits into from
Apr 27, 2021

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 27, 2021

Description

Updates directory and inst_id standards to reflect new usage in pysat. Moves testing to Github Actions.

Replaces #46 and #44

NOTE that NEP 29 is not adhered to in this package (unlike the other pysat packages). The required packages build from fortran and numpy, which does not work for numpy 1.17, 1.18, and 1.19 due to issues beyond the control of the development team here. By July 2022, this versions will not be required, and it is anticipated that NEP 29 can be enforced by then.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

tested locally via

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

@jklenzing jklenzing added this to the 0.3.0 release milestone Apr 27, 2021
@@ -5,4 +5,3 @@ sgp4
pyEphem
apexpy
aacgmv2
pysatMagVect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to put the "--no-binary :OMMBV: pysatMagVect" here is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. My nominal plan forward is to get the CI tests working again here while solving specific pysatMagVect issues in the already open issue.

Copy link
Collaborator

@JonathonMSmith JonathonMSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is warning coming from pysat that comes up in the testing.

FutureWarning: Slicing a positional slice with .loc is not supported, and will raise TypeError in a future version.  Use .loc with labels or .iloc with positions instead.

The warning comes from the line in setitem:

 self.data.loc[key[0], key[1]] = new

This is currently at line 843 of _instrument.py in the develop branch.

@jklenzing jklenzing merged commit 69c7ecc into develop Apr 27, 2021
@jklenzing jklenzing deleted the tst/ga-clean branch April 27, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants