Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/ENH: cdf support for multi_file_day xarray, TIMED SABER #160

Merged
merged 7 commits into from
Apr 12, 2023

Conversation

jklenzing
Copy link
Member

Description

  • Updates the TIMED SABER instrument to use xarray.
  • bug fix: merging of xarray datasets now correctly concatenates across epoch. This bug also affects jpl_gps when loading multiple days
  • Add drop_dims kwarg to remove unmergable data. (In this case, record0 is a string data stamp)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

import datetime as dt
import pysat

roti = pysat.Instrument('jpl', 'gps', tag='roti')
roti.load(date=dt.datetime(2012, 11, 29), end_date=dt.datetime(2012, 12, 2))

saber = pysat.Instrument('timed', 'saber')
saber.load(date=dt.datetime(2019, 1, 1))

In develop, roti will fail to load multiple days.
SABER should now load a full day of data as an xarray object.

Test Configuration

  • Operating system: Monterrey
  • Version number: Python 3.10.8

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing added this to the 0.0.5 Release milestone Apr 6, 2023
@jklenzing jklenzing marked this pull request as ready for review April 6, 2023 20:50
@JonathonMSmith
Copy link
Collaborator

This looks good to me!

@jklenzing jklenzing merged commit 7ccc4bf into develop Apr 12, 2023
@jklenzing jklenzing deleted the enh/cdf_xarray branch April 12, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants