Warn user about empty namespaces #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes extension-related parameters seem to end up not persisted to `setup.cfg`. Issue #506, shows that it might happen for the `namespace` extension, and via a reaction chain cause errors during updates. The changes implemented in this commit try to prevent this reaction chain of errors happening, while also instructing the user on how to workaround in this situation.
Pull Request Test Coverage Report for Build 5595420610002944
💛 - Coveralls |
|
Thanks @abravalheri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sometimes extension-related parameters seem to end up not persisted to
setup.cfg.Issue #506, shows that it might happen for the
namespaceextension, and via a reaction chain cause errors during updates.Approach
The changes implemented in this commit try to prevent this reaction chain of errors happening, by replacing
Nonewith""and instructing the user a workaround for this situation.