Simplify git command, by letting exceptions go through #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is an attempt to improve the UX when the git command is not installed.
As we can see in #712, the error might not be very intuitive to understand.
Approach
In this PR I am tried to simplify the code paths and let the shell exception happen.
(After looking at the commit history for the file I can see that we encountered in the past a lot of problems and with the we accumulated very sophisticated checks. It seems to me that we no longer need to return
None
inpyscaffold.shell.get_git_cmd
, because now it will be executed lazily and therefore wait until the logging is properly configured).