Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #717

Merged
merged 9 commits into from Jun 15, 2023

Conversation

updates:
- [github.com/asottile/pyupgrade: v3.3.1 → v3.4.0](asottile/pyupgrade@v3.3.1...v3.4.0)
- [github.com/PyCQA/autoflake: v2.1.0 → v2.1.1](PyCQA/autoflake@v2.1.0...v2.1.1)
- [github.com/PyCQA/isort: 5.11.5 → 5.12.0](PyCQA/isort@5.11.5...5.12.0)
- [github.com/PyCQA/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 92cc89b to 33b8634 Compare May 8, 2023 18:10
This reverts commit 33b8634.

Most of the updates are note compatible with Python 3.7
- [github.com/PyCQA/autoflake: v2.1.0 →
  v2.1.1](PyCQA/autoflake@v2.1.0...v2.1.1)
@abravalheri
Copy link
Collaborator

There seems to be a problem on macOS for Python 3.10 (installed with brew):

******************** Terminal ($? = 1) ********************
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/.tox/all/lib/python3.10/site-packages/sphinx/__main__.py", line 5, in <module>
    raise SystemExit(main())
  File "/private/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/cirrus-ci-build/.tox/all/lib/python3.10/site-packages/sphinx/cmd/build.py", line 313, in main
    locale.setlocale(locale.LC_ALL, '')
  File "/opt/homebrew/Cellar/python@3.10/3.10.6_2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/locale.py", line 620, in setlocale
    return _setlocale(category, locale)
locale.Error: unsupported locale setting

It seems that this is an old problem and that in the past the Sphinx devs used a workaround to silence this error: sphinx-doc/sphinx#5724.
However, recently, this workaround was removed: sphinx-doc/sphinx@c7d7f29.

I can also see that the associated locale problem was closed in the cpython repository as solved: https://bugs.python.org/issue18378#msg215215 python/cpython#62578.

Not sure why the error is showing up...

It seems that `C.UTF-8` is not POSIS and therefore it is not supported
by macOS, only by GNU/Linux systems.
@abravalheri
Copy link
Collaborator

Now there are some errors with Python 3.12 due to the removal of the imp module, used by the pytest-shutil and pytest-virtualenv plugins...

man-group/pytest-plugins#219

It is been a while that I wanted to remove these plugins... they seem always to bring some sort of complication. Setuptools uses jaraco.envs.VirtualEnv to implement its own venv fixture: https://github.com/pypa/setuptools/blob/b545fc778583f644d6c331773dbe0ea53bfa41af/setuptools/tests/fixtures.py#L104

@coveralls
Copy link

coveralls commented Jun 9, 2023

Coverage Status

coverage: 97.78% (-0.07%) from 97.847% when pulling 8255d44 on pre-commit-ci-update-config into 81911a0 on master.

@abravalheri
Copy link
Collaborator

It seems that replacing:

-  LC_ALL: C.UTF-8
-  LANG: C.UTF-8
+  LC_ALL: C
+  LC_CTYPE: UTF-8
+  LANG: C

Fixes the specific macOS problem (C.UTF-8 is not POSIX).
@FlorianWilhelm do you think this is the correct solution?

If you agree, I can go ahead and also modify the Cirrus templates.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8bb05b5 to e8c48ac Compare June 12, 2023 18:07
@abravalheri
Copy link
Collaborator

Let's add this one for now... we can revert it later.

@abravalheri abravalheri merged commit ee97593 into master Jun 15, 2023
19 of 20 checks passed
@abravalheri abravalheri deleted the pre-commit-ci-update-config branch June 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants