Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow platformdirs 3.x (fix #719) #721

Merged
merged 6 commits into from
Jun 16, 2023

Conversation

musicinmybrain
Copy link
Contributor

Purpose

This PR expands the allowed versions of the platformdirs dependency from 2.x only to 2.x or 3.x. This would fix #719 and is required downstream in Fedora Linux for compatibility with the current version of platformdirs.

Approach

The upper version bound in setup.cfg is trivially adjusted.

Open Questions and Pre-Merge TODOs

[x] Ran tox locally with no regressions

Resources & Links

The sole breaking change in the changelog for platformdirs 3.0.0 is:

  • BREAKING Changed the config directory on macOS to point to */Library/Application Support

@abravalheri
Copy link
Collaborator

Thank you very much for the contribution @musicinmybrain.

The sole breaking change in the changelog for platformdirs 3.0.0 is:
BREAKING Changed the config directory on macOS to point to */Library/Application Support

This might mean that existing configuration files for PyScaffold in macOS will stop working because they will no longer be in the right place, right?


On a unrelated note, @FlorianWilhelm, it seems that the tests started failing recently on macOS with a weird error message: locale.Error: unsupported locale setting.

It seems that this is related to a recent change in sphinx: #717 (comment). Do you have any idea on how to deal with that?

@abravalheri
Copy link
Collaborator

I added automatic migration to ensure backward compatibility.

@coveralls
Copy link

coveralls commented Jun 15, 2023

Coverage Status

coverage: 97.798% (+0.02%) from 97.78% when pulling 3a30c92 on musicinmybrain:platformdirs3 into ee97593 on pyscaffold:master.

@abravalheri abravalheri merged commit c6d23e8 into pyscaffold:master Jun 16, 2023
20 checks passed
@musicinmybrain
Copy link
Contributor Author

I added automatic migration to ensure backward compatibility.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants