Consider underscores in the keys of setup.cfg #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should fix the errors identified in the CI for pyscaffold/pyscaffoldext-dsproject#19. The latest changes in PyScaffold replace `-` with `_` in `setup.cfg`, therefore we should not refer to sections using dashes.
abravalheri
commented
Mar 17, 2021
abravalheri
commented
Mar 17, 2021
`Option` objects use `key` instead of `name` (`name` is for `Section` objects)
FlorianWilhelm
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should fix the errors identified in the CI for
pyscaffold/pyscaffoldext-dsproject#19.
The latest changes in PyScaffold replace
-with_insetup.cfg,therefore we should not refer to sections using dashes.